From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 17 Dec 2009 19:23:58 +0100 Subject: [U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length. In-Reply-To: <200912171736.11000.sr@denx.de> References: <1261056567-5214-1-git-send-email-srk@ti.com> <4B2A5725.50909@googlemail.com> <200912171736.11000.sr@denx.de> Message-ID: <4B2A773E.2010609@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stefan, Stefan Roese wrote: > On Thursday 17 December 2009 17:07:01 Dirk Behme wrote: >>>> It seems like a lot of the omap3 boards share common config options. >>>> What do you think about consolidating the common options to >>>> a sub config file ? >>> Seems a good idea; only if we are sure that the next board doesn't >>> break the current list of common configs. Else, we would be having >>> patches to move config options back to board specific files. >> Does Wolfgang have a basic opinion about sub-configs for configuration >> stuff common for similar boards? > > We already have some similar common config files. Take a look for example at > the AMCC config header: > > include/configs/amcc-common.h I vote for collecting "common config files" in a subdir: include/configs/common for example: include/configs/common/mpc83xx.h collects all common config options for 83xx boards. and so on for all other architectures/manufacturer ... And a "#include "configs/common/..." provides enough information, what will come in with that include ... bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany