public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Himanshu Chauhan <himanshu@symmetricore.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h>
Date: Fri, 18 Dec 2009 17:20:14 +0530	[thread overview]
Message-ID: <4B2B6C76.1070803@symmetricore.com> (raw)
In-Reply-To: <4B2B5A2D.9030402@necel.com>

Shinya Kuribayashi wrote:
> make -C lib_generic/
> zlib.c:31:27: error: asm/unaligned.h: No such file or directory
> zlib.c: In function 'inflate_fast':
> zlib.c:641: warning: implicit declaration of function 'get_unaligned'
> make[1]: *** [zlib.o] Error 1
> make[1]: Leaving directory `/home/skuribay/git/u-boot.git/lib_generic'
> make: *** [lib_generic/libgeneric.a] Error 2
> 
> Import relevant header file from LMO tree (slightly modified to U-Boot).
> 
> Reported-by: Himanshu Chauhan <himanshu@symmetricore.com>
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
> ---
> 
> Himanshu Chauhan wrote:
>> I see that in include directory asm points to asm-mips. Inside 
>> asm-mips there is another link arch->arch-mips which is a dead link. 
>> THere is no directory named arch-mips there.
> 
> This is another topic, let's ignore here.
> 
>> Whats the problem here? Should I pull only the MIPS custodian tree?
> 
> I confirmed that this patch fixes the build error, but not sure
> it works or not.  Just build tested.  And note that there there's
> nothing interesting in the u-boot-mips tree, sorry.
> 
> 
> include/asm-mips/unaligned.h |   26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
> create mode 100644 include/asm-mips/unaligned.h
> 
> diff --git a/include/asm-mips/unaligned.h b/include/asm-mips/unaligned.h
> new file mode 100644
> index 0000000..da6a347
> --- /dev/null
> +++ b/include/asm-mips/unaligned.h
> @@ -0,0 +1,26 @@
> +/*
> + * This file is subject to the terms and conditions of the GNU General 
> Public
> + * License.  See the file "COPYING" in the main directory of this archive
> + * for more details.
> + *
> + * Copyright (C) 2007 Ralf Baechle (ralf at linux-mips.org)
> + */
> +#ifndef _ASM_MIPS_UNALIGNED_H
> +#define _ASM_MIPS_UNALIGNED_H
> +
> +#include <compiler.h>
> +#if defined(__MIPSEB__)
> +# define get_unaligned    __get_unaligned_be
> +# define put_unaligned    __put_unaligned_be
> +#elif defined(__MIPSEL__)
> +# define get_unaligned    __get_unaligned_le
> +# define put_unaligned    __put_unaligned_le
> +#else
> +#  error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
> +#endif
> +
> +# include <linux/unaligned/le_byteshift.h>
> +# include <linux/unaligned/be_byteshift.h>
> +# include <linux/unaligned/generic.h>
> +
> +#endif /* _ASM_MIPS_UNALIGNED_H */

Thanks for sending this patch across. I will try this.

- Himanshu

  reply	other threads:[~2009-12-18 11:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18  6:58 [U-Boot] Build breakage in qemu-mips Himanshu Chauhan
2009-12-18 10:32 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 11:50   ` Himanshu Chauhan [this message]
2009-12-18 12:01   ` Stefan Roese
2009-12-18 12:04     ` Himanshu Chauhan
2009-12-18 12:20       ` Stefan Roese
2009-12-18 12:27         ` Stefan Roese
2009-12-18 12:46           ` Himanshu Chauhan
2009-12-19  0:04             ` Wolfgang Denk
2009-12-19  6:56               ` Himanshu Chauhan
2009-12-19 12:52               ` [U-Boot] [OT] List for sending patches Himanshu Chauhan
2009-12-19 13:54                 ` Mike Frysinger
2009-12-19 19:04                 ` Wolfgang Denk
2009-12-18 13:02         ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 13:06           ` Stefan Roese
2009-12-20  3:59             ` Shinya Kuribayashi
2009-12-18 13:03   ` [U-Boot] [PATCH]: U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-18 13:09   ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Himanshu Chauhan
2009-12-18 13:18     ` Shinya Kuribayashi
2009-12-19  6:57   ` [U-Boot] [PATCH][RESEND]: Fix for U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-20  3:53     ` Shinya Kuribayashi
2009-12-20  6:43       ` Himanshu Chauhan
2009-12-21  4:40         ` Shinya Kuribayashi
2010-03-20 22:58     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2B6C76.1070803@symmetricore.com \
    --to=himanshu@symmetricore.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox