From: Himanshu Chauhan <himanshu@symmetricore.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h>
Date: Sat, 19 Dec 2009 12:26:15 +0530 [thread overview]
Message-ID: <4B2C790F.3010101@symmetricore.com> (raw)
In-Reply-To: <20091219000436.AF2324C026@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Himanshu Chauhan,
>
> In message <4B2B79A9.1000106@symmetricore.com> you wrote:
>> Stefan Roese wrote:
>>> On Friday 18 December 2009 13:20:56 Stefan Roese wrote:
>>>>> I think thats what it is. Both are same.
>>>> No, not exactly. They're nearly identical. But there are differences. Not
>>>> sure if these differences are important though.
>>>>
>>>> Don't get me wrong. I'm not NACK'ing the patch. I'm just pointing out that
>>>> it's different from the Linux version.
>>> Just to make it clear. Here a diff between both versions:
>>>
>>> --- u-boot/include/asm-mips/unaligned.h
>>> +++ linux-2.6/linus/arch/mips/include/asm/unaligned.h
>> I think whatever Shinya sent was modified version of linux's unaligned.h
>> and its working.
>
> Hm... has this really been tested on both big endian and on little
> endian MIPS systems?
>
> Best regards,
>
> Wolfgang Denk
>
Dear Wolfgang,
I am using MIPS emulation on QEMU for my U-Boot. This patch works on big-endian emulation. I haven't
tested it on little endian emulation. My statement of "its working" was for the build fix. So I
won't say its ready for commit before being *actually* tested thoroughly.
Best Regards
Himanshu
next prev parent reply other threads:[~2009-12-19 6:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 6:58 [U-Boot] Build breakage in qemu-mips Himanshu Chauhan
2009-12-18 10:32 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 11:50 ` Himanshu Chauhan
2009-12-18 12:01 ` Stefan Roese
2009-12-18 12:04 ` Himanshu Chauhan
2009-12-18 12:20 ` Stefan Roese
2009-12-18 12:27 ` Stefan Roese
2009-12-18 12:46 ` Himanshu Chauhan
2009-12-19 0:04 ` Wolfgang Denk
2009-12-19 6:56 ` Himanshu Chauhan [this message]
2009-12-19 12:52 ` [U-Boot] [OT] List for sending patches Himanshu Chauhan
2009-12-19 13:54 ` Mike Frysinger
2009-12-19 19:04 ` Wolfgang Denk
2009-12-18 13:02 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 13:06 ` Stefan Roese
2009-12-20 3:59 ` Shinya Kuribayashi
2009-12-18 13:03 ` [U-Boot] [PATCH]: U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-18 13:09 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Himanshu Chauhan
2009-12-18 13:18 ` Shinya Kuribayashi
2009-12-19 6:57 ` [U-Boot] [PATCH][RESEND]: Fix for U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-20 3:53 ` Shinya Kuribayashi
2009-12-20 6:43 ` Himanshu Chauhan
2009-12-21 4:40 ` Shinya Kuribayashi
2010-03-20 22:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2C790F.3010101@symmetricore.com \
--to=himanshu@symmetricore.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox