public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 bbg board
Date: Tue, 29 Dec 2009 23:41:06 +0100	[thread overview]
Message-ID: <4B3A8582.8050908@denx.de> (raw)
In-Reply-To: <2f495dc80912131828k2fad871eg81458220e8692a43@mail.gmail.com>

Fred Fan wrote:
> HI Stefano Babic,
>    Sorry, I just see your and wolfgang's mail. In this days, I am
> prepare new soc's  kernel MSL code.
> When I just finished my coding, I have same issue too. But during I
> identify this issue, the issue is
> disappeared.
>    I does not change lowlevel_init.s. Maybe I removed some definitions
> of clock register.
>    I will check it ASAP.

Hi Fred,

do not worry, I could find where the problem is located. I started from
the IMX51 BSP, changing code to adapt for the u-boot top of tree, and
then I applied all changes you sent in your patchset. So I could check
step by step where I had to look.

I do not find any issue in the cpu/mx51/clock.c and in the clock
definitions, that you rearranged after the first review, so in this file
everything seems ok ;)

Definitely I checked with the debugger that the problem arises in the
first initialization of the clock registers in lowlevel_init.S (after
the init_clock label).
I replaced the file with the one I found in the BSP and the board runs
now flawlessly.

I have already removed the flashHeader.S, adding a new image format to
support the i.MX51 processor and its DCD table.

I have opened another issue, too. I have seen that the name "babbage" is
quite disappeared and on the Freescale's website this board is named now
"mx51evk". I know you have already changed the name of the board, but I
think the name "babbage" can confuse. Better should be to rename the
board with the name we find in the official documentation. I know you
already did this job, I can only volunteer myself to do that...

What do you think if I take over the job and I will resend all patches
to the ML ? In this way I can easier integrate my changes, if you agree.
Should be ok for you ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-12-29 22:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 14:47 [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 bbg board Fred Fan
2009-09-23 21:47 ` Wolfgang Denk
2009-12-01 16:44   ` Fred Fan
2009-12-01 21:15     ` Wolfgang Denk
2009-12-04 11:16     ` Stefano Babic
2009-12-14  2:28       ` Fred Fan
2009-12-29 22:41         ` stefano babic [this message]
2009-09-24  4:35 ` Prafulla Wadaskar
2009-09-24  6:34   ` [U-Boot] [PATCH] imx51:Add support basic boot code of freescaleimx51 " Fan YeFeng-R01011
  -- strict thread matches above, loose matches on Subject: below --
2009-09-20 17:28 [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 " gareatech at gmail.com
2009-09-21 17:55 ` Magnus Lilja
2009-09-21 20:58   ` Fabio Estevam
     [not found]   ` <2f495dc80909221219n2f6f303dw478871aede988a7a@mail.gmail.com>
2009-09-22 19:52     ` Magnus Lilja
2009-09-22 20:28       ` Fred Fan
2009-09-22 20:04     ` Magnus Lilja
2009-09-22 20:29       ` Fred Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B3A8582.8050908@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox