From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Tue, 29 Dec 2009 23:41:06 +0100 Subject: [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 bbg board In-Reply-To: <2f495dc80912131828k2fad871eg81458220e8692a43@mail.gmail.com> References: <12537172421605-git-send-email-fanyefeng@gmail.com> <20090923214720.67D18832E864@gemini.denx.de> <2f495dc80912010844h6b4aa1e4i4588f808384b6272@mail.gmail.com> <4B18EF74.8090401@denx.de> <2f495dc80912131828k2fad871eg81458220e8692a43@mail.gmail.com> Message-ID: <4B3A8582.8050908@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Fred Fan wrote: > HI Stefano Babic, > Sorry, I just see your and wolfgang's mail. In this days, I am > prepare new soc's kernel MSL code. > When I just finished my coding, I have same issue too. But during I > identify this issue, the issue is > disappeared. > I does not change lowlevel_init.s. Maybe I removed some definitions > of clock register. > I will check it ASAP. Hi Fred, do not worry, I could find where the problem is located. I started from the IMX51 BSP, changing code to adapt for the u-boot top of tree, and then I applied all changes you sent in your patchset. So I could check step by step where I had to look. I do not find any issue in the cpu/mx51/clock.c and in the clock definitions, that you rearranged after the first review, so in this file everything seems ok ;) Definitely I checked with the debugger that the problem arises in the first initialization of the clock registers in lowlevel_init.S (after the init_clock label). I replaced the file with the one I found in the BSP and the board runs now flawlessly. I have already removed the flashHeader.S, adding a new image format to support the i.MX51 processor and its DCD table. I have opened another issue, too. I have seen that the name "babbage" is quite disappeared and on the Freescale's website this board is named now "mx51evk". I know you have already changed the name of the board, but I think the name "babbage" can confuse. Better should be to rename the board with the name we find in the official documentation. I know you already did this job, I can only volunteer myself to do that... What do you think if I take over the job and I will resend all patches to the ML ? In this way I can easier integrate my changes, if you agree. Should be ok for you ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================