[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[Khasim Syed Mohammed]

[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[Khasim Syed Mohammed]

On Wed, Jan 6, 2010 at 12:52 AM, Nishanth Menon
<menon.nishanth@gmail.com> wrote:
> does this really belong to this series?
I lately figured out that all are independent. This can be merged separately.

Sandeep can you consider this patch as there are no comments. I will
work on the other two and submit them accordingly.

Regards,
Khasim


> On Tue, Jan 5, 2010 at 10:13 AM, Khasim Syed Mohammed
> <khasim@beagleboard.org> wrote:
>> From 3aa4b510a95b5313dc103c286eea44a6054b67d4 Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim <khasim@ti.com>
>> Date: Tue, 5 Jan 2010 20:52:36 +0530
>> Subject: [PATCH] Enable I2C bus switching
>>
>> OMAP3 supports Multiple I2C channels, this patch allows
>> us to use i2c dev <bus no> command to switch between busses.
>>
>> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>> ---
>> ?drivers/i2c/omap24xx_i2c.c ? ? | ? ?5 +++++
>> ?include/configs/omap3_beagle.h | ? ?4 ++++
>> ?2 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>> index ff18991..a9250be 100644
>> --- a/drivers/i2c/omap24xx_i2c.c
>> +++ b/drivers/i2c/omap24xx_i2c.c
>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>
>> ? ? ? ?return 0;
>> ?}
>> +
>> +int i2c_get_bus_num(void)
>> +{
>> + ? ? ? return ((int) current_bus);
>> +}
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index d1c9cd0..fa26b35 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -100,6 +100,10 @@
>> ?/* DDR - I use Micron DDR */
>> ?#define CONFIG_OMAP3_MICRON_DDR ? ? ? ? ? ? ? ?1
>>
>> +/* Enable Multi Bus support for I2C */
>> +#define CONFIG_I2C_MULTI_BUS ? ? ? ? ? 1
>> +#define CONFIG_SYS_I2C_NOPROBES ? ? ? ? ? ? ? ?{0x0,0x0}
>> +
>> ?/* commands to include */
>> ?#include <config_cmd_default.h>
>>
>> --
>> 1.5.6.3
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>

[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[Paulraj, Sandeep]

> 
> On Wed, Jan 6, 2010 at 12:52 AM, Nishanth Menon
> <menon.nishanth@gmail.com> wrote:
> > does this really belong to this series?
> I lately figured out that all are independent. This can be merged
> separately.
> 
> Sandeep can you consider this patch as there are no comments. I will
> work on the other two and submit them accordingly.

Again it needs to spend a little more time on the list to give others a fair chance at review.

Also I see it involves I2c so even though the change seems simple enough it should go through u-boot-i2c or I should atleast wait for some time for an ACK from Heiko.

I've applied such patches(e.g NAND, I2c and net related stuff)  but only after the respective custodians are OK with it 
> 
> Regards,
> Khasim
> 
> 
> > On Tue, Jan 5, 2010 at 10:13 AM, Khasim Syed Mohammed
> > <khasim@beagleboard.org> wrote:
> >> From 3aa4b510a95b5313dc103c286eea44a6054b67d4 Mon Sep 17 00:00:00 2001
> >> From: Syed Mohammed Khasim <khasim@ti.com>
> >> Date: Tue, 5 Jan 2010 20:52:36 +0530
> >> Subject: [PATCH] Enable I2C bus switching
> >>
> >> OMAP3 supports Multiple I2C channels, this patch allows
> >> us to use i2c dev <bus no> command to switch between busses.
> >>
> >> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> >> ---
> >> ?drivers/i2c/omap24xx_i2c.c ? ? | ? ?5 +++++
> >> ?include/configs/omap3_beagle.h | ? ?4 ++++
> >> ?2 files changed, 9 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
> >> index ff18991..a9250be 100644
> >> --- a/drivers/i2c/omap24xx_i2c.c
> >> +++ b/drivers/i2c/omap24xx_i2c.c
> >> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
> >>
> >> ? ? ? ?return 0;
> >> ?}
> >> +
> >> +int i2c_get_bus_num(void)
> >> +{
> >> + ? ? ? return ((int) current_bus);
> >> +}
> >> diff --git a/include/configs/omap3_beagle.h
> b/include/configs/omap3_beagle.h
> >> index d1c9cd0..fa26b35 100644
> >> --- a/include/configs/omap3_beagle.h
> >> +++ b/include/configs/omap3_beagle.h
> >> @@ -100,6 +100,10 @@
> >> ?/* DDR - I use Micron DDR */
> >> ?#define CONFIG_OMAP3_MICRON_DDR ? ? ? ? ? ? ? ?1
> >>
> >> +/* Enable Multi Bus support for I2C */
> >> +#define CONFIG_I2C_MULTI_BUS ? ? ? ? ? 1
> >> +#define CONFIG_SYS_I2C_NOPROBES ? ? ? ? ? ? ? ?{0x0,0x0}
> >> +
> >> ?/* commands to include */
> >> ?#include <config_cmd_default.h>
> >>
> >> --
> >> 1.5.6.3
> >> _______________________________________________
> >> U-Boot mailing list
> >> U-Boot at lists.denx.de
> >> http://lists.denx.de/mailman/listinfo/u-boot
> >>
> >

[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[Heiko Schocher]

Hello Khasim Syed,

Khasim Syed Mohammed wrote:
>>From 3aa4b510a95b5313dc103c286eea44a6054b67d4 Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Tue, 5 Jan 2010 20:52:36 +0530
> Subject: [PATCH] Enable I2C bus switching
> 
> OMAP3 supports Multiple I2C channels, this patch allows
> us to use i2c dev <bus no> command to switch between busses.
> 
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>

Acked-by: Heiko Schocher <hs@denx.de>

Sandeep, as this is a patchseries, which should go through your
repo, can you pick up this patch?

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] TI:OMAP: [PATCH 4/4] Enable I2C bus switching

[Paulraj, Sandeep]

> 
> Hello Khasim Syed,
> 
> Khasim Syed Mohammed wrote:
> >>From 3aa4b510a95b5313dc103c286eea44a6054b67d4 Mon Sep 17 00:00:00 2001
> > From: Syed Mohammed Khasim <khasim@ti.com>
> > Date: Tue, 5 Jan 2010 20:52:36 +0530
> > Subject: [PATCH] Enable I2C bus switching
> >
> > OMAP3 supports Multiple I2C channels, this patch allows
> > us to use i2c dev <bus no> command to switch between busses.
> >
> > Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> 
> Acked-by: Heiko Schocher <hs@denx.de>
> 
> Sandeep, as this is a patchseries, which should go through your
> repo, can you pick up this patch?

OK Thanks.
I'll pick up this patch

> 
> bye
> Heiko