[U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs

Tom
2010-01-12T13:38:39Z

Vipin Kumar wrote:
> Hello Tom,
>
>>>> I am planning to keep the patch order as it is but I would remove
>>>> dependencies eg. SPEAr600 would not contain code that depends on
>>>> a driver added later and so on.
>>>>
>>>> This should also be OK. Right?
>>> It should remove the 'git bisect' issue, which is the important thing to
>>> me. The way you did it in v3 should work, its just a bit uglier than
>>> doing it the "right" way that I outlined above. Eg you modify spear.h
>>> and config.mk each time you add a new driver, basically tweaking the
>>> board support as the patch sequence progresses instead of just adding
>>> proper board support in 1 patch at the end.
>>>
>>> Also, its a bit ugly to add both spear arch support as well as board
>>> support in patch 2/11. Ideally you'd have 1 patch adding spear
>>> architectural support, then additional patches for drivers, then patches
>>> for boards.
>>>
>> On 2/11, this patch must be split.
>> Arch support split from board support.
>>
>> Moving the driver support before board support would simplify the
>> review. The subsystem custodians would only have to review what they
>> are responsible for. I would also recommend doing this.
>>
>
> Changes done as you suggested in patch set version4
>
Thanks,
I am reviewing this patch set now.
So far it looks ok wrt mechanical checking.
Tom

> Regards
> Vipin