[U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs

Vipin KUMAR
2010-01-08T13:28:53Z

Hello Tom,

> > This patch set is a reworked patch which incorporates all review
> feedbacks from
> > earlier earlier mails
> >
> > This patch set contains the support for 4 SoCs
> > SPEAr600
> > SPEAr300
> > SPEAr310
> > SPEAr320
> >
> > SPEAr is an ARM based SoC which supports rich set of peripherals like
> Ethernet,
> > USB Host, USB Device etc to support various general
> applications
> >
> > For further info on SPEAr SoC, please see README.spear also contained
> in the
> > patch set.
> >
> > Vipin (9):
> > Added README.spear
> > SPEAr600 SoC support added
> > SPEAr300 SoC support added
> > SPEAr310 SoC support added
> > SPEAr320 SoC support added
> > i2c driver support for SPEAr SoCs
> > smi driver support for SPEAr SoCs
> > nand(fsmc) driver support for SPEAr SoCs
> > usbd driver support for SPEAr SoCs
>
> This review is mechanical.
>
> Whitespace/formatting checking with checkpatch.pl is in general ok.
> Some warnings about braces, fix if you think appropriate

Braces warnings have not been fixed. I thought it is safer this way

> On patch 9,
> ERROR: "foo * bar" should be "foo *bar"
> #283: FILE: drivers/usb/gadget/spr_udc.c:229:
> +static void usbputpcktofifo(int epNum, u8 * bufp, u32 len)
> These should fixed

Corrected in v3

> The readme has trailing whitespace issues that were caught in the 'git
> am '
> Please fix.
>
Corrected in v3

> On patch 9, usb.
> There are some merge warnings.
> Applying: usbd driver support for SPEAr SoCs
> error: patch failed: drivers/serial/usbtty.h:31
> error: drivers/serial/usbtty.h: patch does not apply
> Using index info to reconstruct a base tree...
> Falling back to patching base and 3-way merge...
> Auto-merged drivers/serial/usbtty.h
>
> There are some recent updates for usb.
> Please rebase you source.
>
The v3 patch is rebased on the latest master

> On MAKEALL arm
> Spear boards fail to build
> Errors similar to this
>
> Assembler messages:
> Fatal error: can't create
> build/board/spear/spear300/../common/spr_misc.o: No
> such file or directory
> Assembler messages:
> Fatal error: can't create
> build/board/spear/spear300/../common/spr_lowlevel_init.o: No such file
> or directory
>
> The way i test MAKEALL is to define the BUILD_DIR to be something that
> is not
> the source directory. Please rerun MAKEALL this way and resolve these
> errors.
>
Corrected in v3 patch set

> I will do a more detailed review soon.
>
Thanks for your help in reviewing the code. Please review the version3
patch set

Regards,
Vipin