public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Call gentenv_IPaddr only if CONFIG_CMD_NET set
Date: Fri, 08 Jan 2010 22:26:24 +0100	[thread overview]
Message-ID: <4B47A300.4030509@free.fr> (raw)
In-Reply-To: <1262985580-18163-1-git-send-email-albert.aribaud@free.fr>

Albert Aribaud a ?crit :

> ARM Boards for which CONFIG_CMD_NET is unset still
> call getenv_IPaddr from lib_arm/board.c even though
> net/net.c (which defines gentenv_IPaddr) will not
> be compiled and linked. This patch fixes this by
> making the call conditional to CONFIG_CMD_NET.
> 
> Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>

Regarding this fix I have a SCM related question:

I was hit by this problem while preparing my Orion 5x patch for final 
submission (strangely enough I was not hit before even though I never 
had CONFIG_CMD_NET set).

This means my Orion patches will depend on this one (but I felt I should 
submit it separately as it was totally unrelated to Orion/Ed Mini 
support). Can I submit the Orion patches and just mention the 
dependency? Or do I also do the fix in my Orion patches and let GIT sort 
things out?

Amicalement,
-- 
Albert.

  reply	other threads:[~2010-01-08 21:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08 21:19 [U-Boot] [PATCH] Call gentenv_IPaddr only if CONFIG_CMD_NET set Albert Aribaud
2010-01-08 21:26 ` Albert ARIBAUD [this message]
2010-01-08 21:37 ` Ben Warren
2010-01-08 21:44   ` Albert ARIBAUD
2010-01-08 21:50     ` Ben Warren
2010-01-08 22:11       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B47A300.4030509@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox