From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Call gentenv_IPaddr only if CONFIG_CMD_NET set
Date: Fri, 08 Jan 2010 22:44:36 +0100 [thread overview]
Message-ID: <4B47A744.6060700@free.fr> (raw)
In-Reply-To: <4B47A59C.6090405@gmail.com>
Ben Warren a ?crit :
> Hi Albert,
>
> Albert Aribaud wrote:
>> ARM Boards for which CONFIG_CMD_NET is unset still
>> call getenv_IPaddr from lib_arm/board.c even though
>> net/net.c (which defines gentenv_IPaddr) will not
>> be compiled and linked. This patch fixes this by
>> making the call conditional to CONFIG_CMD_NET.
>>
> There's already been quite a bit of discussion about this, and another
> fix is in the queue:
>
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/73200/match=getenv_IPaddr
>
>
> Correct me if it doesn't fix your problem.
>
> regards,
> Ben
Thanks Ben, I obviously missed this... I can try and mumble an excuse
about it being too near New Year's Eve.
As long as it allows building with ARM and no CONFIG_CMD_NET, it's fine
with me.
Does its being "in the queue" (but obviously not committed yet as I'd
pulled and checked before posting) allow me to submit patches dependent
on it?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-01-08 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 21:19 [U-Boot] [PATCH] Call gentenv_IPaddr only if CONFIG_CMD_NET set Albert Aribaud
2010-01-08 21:26 ` Albert ARIBAUD
2010-01-08 21:37 ` Ben Warren
2010-01-08 21:44 ` Albert ARIBAUD [this message]
2010-01-08 21:50 ` Ben Warren
2010-01-08 22:11 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B47A744.6060700@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox