[U-Boot] [PATCH] Call gentenv_IPaddr only if CONFIG_CMD_NET set

Ben Warren
2010-01-08T21:50:12Z

Albert ARIBAUD wrote:
> Ben Warren a ?crit :
>> Hi Albert,
>>
>> Albert Aribaud wrote:
>>> ARM Boards for which CONFIG_CMD_NET is unset still
>>> call getenv_IPaddr from lib_arm/board.c even though
>>> net/net.c (which defines gentenv_IPaddr) will not
>>> be compiled and linked. This patch fixes this by
>>> making the call conditional to CONFIG_CMD_NET.
>>>
>> There's already been quite a bit of discussion about this, and
>> another fix is in the queue:
>>
>> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/73200/match=getenv_IPaddr
>>
>>
>> Correct me if it doesn't fix your problem.
>>
>> regards,
>> Ben
>
> Thanks Ben, I obviously missed this... I can try and mumble an excuse
> about it being too near New Year's Eve.
>
Pas de probleme.
> As long as it allows building with ARM and no CONFIG_CMD_NET, it's
> fine with me.
>
> Does its being "in the queue" (but obviously not committed yet as I'd
> pulled and checked before posting) allow me to submit patches
> dependent on it?
>
I've asked WD to apply the patch, but he hasn't acted yet. Do your
patches affect the files touched by this patch, or are you concerned
about the link error (undefined reference to 'getenv_IPaddr')? If the
former, don't submit yet. If the latter, go ahead.
> Amicalement,
regards,
Ben