[U-Boot] Flex-OneNAND related build breakage (was Re: MIPS: build status (2010.01))

[U-Boot] Flex-OneNAND related build breakage (was Re: MIPS: build status (2010.01))

[Shinya Kuribayashi]

Hi Rohit, Amul, and Kyungmin (Samsung people),

Shinya Kuribayashi wrote:
> Build warnings / errors could be categorized into five groups:
> 
> 3) env_onenand.c: CONFIG_ENV_{ADDR,SIZE}_FLEX undeclared build error

In the following commit, Flex-OneNAND support was introduced:

commit c758e947aa7d39a2be607ecdedd818ad300807b2
Author: Amul Kumar Saha <amul.saha@samsung.com>
Date:   Wed Nov 4 10:38:46 2009 +0530

    ENV Variable support for Flex-OneNAND
    
    Define and use CONFIG_ENV_ADDR_FLEX and CONFIG_ENV_SIZE_FLEX
    for storing environment variables.
    
    Signed-off-by: Rohit Hagargundgi <h.rohit@samsung.com>
    Signed-off-by: Amul Kumar Saha <amul.saha@samsung.com>

However, it breaks the existing 'normal' OneNAND user's builds like this:

LOG/vct_platinum_onenand.ERR
-----------------------------
env_onenand.c: In function 'env_relocate_spec':
env_onenand.c:70: error: 'CONFIG_ENV_ADDR_FLEX' undeclared (first use in this function)
env_onenand.c:70: error: (Each undeclared identifier is reported only once
env_onenand.c:70: error: for each function it appears in.)
env_onenand.c: In function 'saveenv':
env_onenand.c:106: error: 'CONFIG_ENV_ADDR_FLEX' undeclared (first use in this function)
env_onenand.c:107: error: 'CONFIG_ENV_SIZE_FLEX' undeclared (first use in this function)
make[1]: *** [env_onenand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [common/libcommon.a] Error 2

Affected (MIPS) targets:
- MIPS Micronas VCT Premium/Platinum/Platinum AVC (vct_*_onenand_config).
- I'm not sure about other OneNAND users in mainline.

Having a look at the code, and from CONFIG_ENV_{ADDR,SIZE}_FLEX names,
they're apparently Flex-OneNAND specific configurations, right?  If so
'normal' OneNAND users don't want to have, I'm afraid.

Any comments on how, and where supposed to be fixed?

[U-Boot] Flex-OneNAND related build breakage (was Re: MIPS: build status (2010.01))

[Shinya Kuribayashi]

On 1/11/10 1:09 PM, AMIT KUMARSHARMA wrote:
> HI Shinya,
>
> Please go thorugh below link , issue is already resolved,

Ah, thanks.  I missed that.