From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Mon, 11 Jan 2010 10:44:09 +0100
Subject: [U-Boot] [PATCH v3 06/11] SPEAr : i2c driver support addded
In-Reply-To: <1262958547-2508-7-git-send-email-vipin.kumar@st.com>
References: <1262958547-2508-1-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-2-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-3-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-4-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-5-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-6-git-send-email-vipin.kumar@st.com>
	<1262958547-2508-7-git-send-email-vipin.kumar@st.com>
Message-ID: <4B4AF2E9.50306@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Vipin,

Vipin KUMAR wrote:
> Signed-off-by: Vipin <vipin.kumar@st.com>
> ---
>  drivers/i2c/Makefile                 |    1 +
>  drivers/i2c/spr_i2c.c                |  340 ++++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-spear/spr_i2c.h |  146 +++++++++++++++
>  include/configs/spear.h              |   11 +
>  4 files changed, 498 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 drivers/i2c/Makefile
>  create mode 100755 drivers/i2c/spr_i2c.c
>  create mode 100755 include/asm-arm/arch-spear/spr_i2c.h
> 
[...]
> diff --git a/drivers/i2c/spr_i2c.c b/drivers/i2c/spr_i2c.c
> new file mode 100755
> index 0000000..497ca47
> --- /dev/null
> +++ b/drivers/i2c/spr_i2c.c
[...]
> +/*
> + * i2c_set_bus_speed - Set the i2c speed
> + * @speed:	required i2c speed
> + *
> + * Set the i2c speed.
> + */
> +void i2c_set_bus_speed(int speed)
> +{
> +	if (speed >= I2C_MAX_SPEED) {
> +		set_speed(IC_SPEED_MODE_MAX);

No brackets for single statement, please,

> +

blank line not needed here.

> +	} else if (speed >= I2C_FAST_SPEED) {
> +		set_speed(IC_SPEED_MODE_FAST);
> +

same as above.

> +	} else {
> +		set_speed(IC_SPEED_MODE_STANDARD);
> +	}
> +}
> +
> +/*
> + * i2c_get_bus_speed - Gets the i2c speed
> + *
> + * Gets the i2c speed.
> + */
> +int i2c_get_bus_speed(void)
> +{
> +	u32 cntl;
> +
> +	cntl = (readl(&i2c_regs_p->ic_con) & IC_CON_SPD_MSK);
> +
> +	if (cntl == IC_CON_SPD_HS) {
> +		return I2C_MAX_SPEED;
> +

here too, please fix globally.

[...]

If you fix this small Coding Style issues, you get my:

Acked-by: Heiko Schocher<hs@denx.de>

thanks!

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany