From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Lilja Date: Mon, 11 Jan 2010 19:41:57 +0100 Subject: [U-Boot] [PATCH] SPI: Fix 32 bit transfers in mxc_spi.c In-Reply-To: References: <1257965907-5622-1-git-send-email-lilja.magnus@gmail.com> <20091202223201.157174C025@gemini.denx.de> <59b21cf20912022313m3e684e2ge1314a0f0f4868b@mail.gmail.com> <4B4243C2.4030900@gmail.com> Message-ID: <4B4B70F5.7090203@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Guennadi Liakhovetski skrev: >>>> Hm, I'm afraid, I broke more than just that. Now that I look at this loop, >>>> looks like I broke not only 32-bit transfers, but also all transfers with >>>> bitlen > 16, and this fix is then incomplete - it doesn't fix cases with >>>> bitlen > 32. Magnus, looks like you also only use single-block (bitlen=32) >>>> transfers? Do you have a chance to test > 32-bit transfers too? >>> No, I don't have anything suitable on the SPI bus that would allow me >>> to test > 32-bit transfer. >> >> So, what was the verdict? I can only test SPI with the ATLAS (32 bit xfers). >> >> Can the patch be accepted even though it doesn't fix all problems or >> does it have to a "fix-everything"-patch? > > I would prefer a proper fix, or an explicit restriction on transfer > length. In that case it will be the latter, explicit restriction on transfer length with a printf and returning an error code from spi_xfer. Regards, Magnus