[U-Boot] [PATCH V4 1/3] Initial support for Marvell Orion5x SoC

[Albert ARIBAUD <albert.aribaud@free.fr>]

Prafulla Wadaskar a ?crit :

>>  cpu/arm926ejs/orion5x/cpu.c              |  258 
> ....snip....
> 
>> +int print_cpuinfo(void)

> The above checks should be #ifdefed with CONFIG_88FXXXX (SOC type)
> There is no need to check for all SoC names, this will also reduce code size.

As stated in my answer re: the declaration of the dev/rev constants, I 
believe that this place, of all place, should not be conditionally built 
depending on the device, because it is there to positively identify the 
device/revision we're running our code on even if not built for the 
right variant.

Amicalement,
-- 
Albert.