From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Wed, 13 Jan 2010 08:49:09 +0100
Subject: [U-Boot] [PATCH V4 1/3] Initial support for Marvell Orion5x SoC
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E2030816251F@SC-VEXCH1.marvell.com>
References: <73173D32E9439E4ABB5151606C3E19E2030816251F@SC-VEXCH1.marvell.com>
Message-ID: <4B4D7AF5.30906@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Prafulla Wadaskar a ?crit :

>>  cpu/arm926ejs/orion5x/cpu.c              |  258 
> ....snip....
> 
>> +int print_cpuinfo(void)

> The above checks should be #ifdefed with CONFIG_88FXXXX (SOC type)
> There is no need to check for all SoC names, this will also reduce code size.

As stated in my answer re: the declaration of the dev/rev constants, I 
believe that this place, of all place, should not be conditionally built 
depending on the device, because it is there to positively identify the 
device/revision we're running our code on even if not built for the 
right variant.

Amicalement,
-- 
Albert.