public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 09/12] SPEAr : Support added for SPEAr300 board
Date: Thu, 14 Jan 2010 16:41:50 +0530	[thread overview]
Message-ID: <4B4EFBF6.7010306@st.com> (raw)
In-Reply-To: <4B4DCB40.7010400@windriver.com>

Hello Tom,

>  include/configs/spear.h         |   25 +++++++++++++++--
>  6 files changed, 171 insertions(+), 3 deletions(-)
>  create mode 100755 board/spear/spear300/Makefile
>  create mode 100755 board/spear/spear300/config.mk
>  create mode 100755 board/spear/spear300/spear300.c
> 
> <snip>
> diff --git a/include/configs/spear.h b/include/configs/spear.h
> index a625c31..15a8241 100755
> --- a/include/configs/spear.h
> +++ b/include/configs/spear.h
> @@ -28,7 +28,12 @@
>   * High Level Configuration Options
>   * (easy to change)
>   */
> +#if defined(CONFIG_MK_spear600)
>  #define CONFIG_SPEAR600                1
> +#elif defined(CONFIG_MK_spear300)
> +#define CONFIG_SPEAR3XX                1
> +#define CONFIG_SPEAR300                1
> +#endif
> 
> There should be a config file per board.
> The common parts can be kept in a separate file
> So the should be 'spear300.h' etc.

Is it mandatory ?
Since there are already some board configs in Makefile
eg. P2020RDB_config and P1011RDB_config etc

In fact, I got this comment from Wolfgang on my first patch set
that these are similar boards and can be combined

Regards
Vipin

  reply	other threads:[~2010-01-14 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 13:31 [U-Boot] [PATCH v4 09/12] SPEAr : Support added for SPEAr300 board Tom
2010-01-14 11:11 ` Vipin KUMAR [this message]
2010-01-14 15:49   ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2010-01-11 11:15 [U-Boot] [PATCH v4 00/12] Support for SPEAr SoCs Vipin KUMAR
2010-01-11 11:15 ` [U-Boot] [PATCH v4 01/12] SPEAr : Adding README.spear in doc Vipin KUMAR
2010-01-11 11:15   ` [U-Boot] [PATCH v4 02/12] SPEAr : Adding basic SPEAr architecture support Vipin KUMAR
2010-01-11 11:15     ` [U-Boot] [PATCH v4 03/12] SPEAr : i2c driver support added for SPEAr SoCs Vipin KUMAR
2010-01-11 11:15       ` [U-Boot] [PATCH v4 04/12] SPEAr : smi driver support " Vipin KUMAR
2010-01-11 11:15         ` [U-Boot] [PATCH v4 05/12] SPEAr : nand " Vipin KUMAR
2010-01-11 11:15           ` [U-Boot] [PATCH v4 06/12] SPEAr : usbd " Vipin KUMAR
2010-01-11 11:15             ` [U-Boot] [PATCH v4 07/12] SPEAr : Support added for SPEAr600 board Vipin KUMAR
2010-01-11 11:15               ` [U-Boot] [PATCH v4 08/12] SPEAr : Support for HW mac id read/write from i2c mem Vipin KUMAR
2010-01-11 11:15                 ` [U-Boot] [PATCH v4 09/12] SPEAr : Support added for SPEAr300 board Vipin KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4EFBF6.7010306@st.com \
    --to=vipin.kumar@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox