* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
@ 2010-01-12 19:07 Khasim Syed Mohammed
2010-01-17 0:11 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-12 19:07 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
2010-01-12 19:07 [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4 Khasim Syed Mohammed
@ 2010-01-17 0:11 ` Tom
2010-01-18 13:50 ` Khasim Syed Mohammed
0 siblings, 1 reply; 6+ messages in thread
From: Tom @ 2010-01-17 0:11 UTC (permalink / raw)
To: u-boot
Khasim Syed Mohammed wrote:
> From c8d47f8b064329676a0f04cff95eef05fe7f24ba Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Wed, 13 Jan 2010 00:26:17 +0530
> Subject: [PATCH] Add 720Mhz support for Beagle Rev C4
>
> Use the Generic TWL and Clock APIs to get beagle
> Rev C4 running at 720Mhz
>
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> ---
> board/ti/beagle/beagle.c | 21 +++++++++++++++++++--
> 1 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index 02e90b5..338a8dc 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -132,8 +132,27 @@ int misc_init_r(void)
> struct gpio *gpio5_base = (struct gpio *)OMAP34XX_GPIO5_BASE;
> struct gpio *gpio6_base = (struct gpio *)OMAP34XX_GPIO6_BASE;
>
> + beagle_identify();
> +
> twl4030_power_init();
> twl4030_led_init();
> +
> + if (beagle_revision == REVISION_C4) {
> +
ws
remove 2 tabs in the previous line
This was caught in checkpatch, I will do a full review on the next revision
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
2010-01-17 0:11 ` Tom
@ 2010-01-18 13:50 ` Khasim Syed Mohammed
0 siblings, 0 replies; 6+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-18 13:50 UTC (permalink / raw)
To: u-boot
Tom,
On Sun, Jan 17, 2010 at 5:41 AM, Tom <Tom.Rix@windriver.com> wrote:
> Khasim Syed Mohammed wrote:
>>
>> From c8d47f8b064329676a0f04cff95eef05fe7f24ba Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim <khasim@ti.com>
>> Date: Wed, 13 Jan 2010 00:26:17 +0530
>> Subject: [PATCH] Add 720Mhz support for Beagle Rev C4
>>
>> Use the Generic TWL and Clock APIs to get beagle
>> Rev C4 running at 720Mhz
>>
>> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>> ---
>> ?board/ti/beagle/beagle.c | ? 21 +++++++++++++++++++--
>> ?1 files changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
>> index 02e90b5..338a8dc 100644
>> --- a/board/ti/beagle/beagle.c
>> +++ b/board/ti/beagle/beagle.c
>> @@ -132,8 +132,27 @@ int misc_init_r(void)
>> ? ? ? ?struct gpio *gpio5_base = (struct gpio *)OMAP34XX_GPIO5_BASE;
>> ? ? ? ?struct gpio *gpio6_base = (struct gpio *)OMAP34XX_GPIO6_BASE;
>>
>> + ? ? ? beagle_identify();
>> +
>> ? ? ? ?twl4030_power_init();
>> ? ? ? ?twl4030_led_init();
>> +
>> + ? ? ? if (beagle_revision == REVISION_C4) {
>> +
>
> ws
> remove 2 tabs in the previous line
> This was caught in checkpatch, ?I will do a full review on the next revision
>
I found some re-basing issues as few files were changed after this submissions.
I am hereby re-sending all these patches after re-basing and I have
incorporated all your comments as well.
Please consider these and discard the previous one.
Regards,
Khasim
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
@ 2010-01-18 13:59 Khasim Syed Mohammed
2010-01-24 0:26 ` Tom
0 siblings, 1 reply; 6+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-18 13:59 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
2010-01-18 13:59 Khasim Syed Mohammed
@ 2010-01-24 0:26 ` Tom
2010-01-24 8:37 ` Dirk Behme
0 siblings, 1 reply; 6+ messages in thread
From: Tom @ 2010-01-24 0:26 UTC (permalink / raw)
To: u-boot
Khasim Syed Mohammed wrote:
> From c0bdd7fbdf343ada1ecc65541ec3de1a5fdbfe79 Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Mon, 18 Jan 2010 18:51:04 +0530
> Subject: [PATCH] Add 720Mhz support for Beagle Rev C4
>
> Use the Generic TWL and Clock APIs to get beagle
> Rev C4 running at 720Mhz
Why is it necessary to run mpu at 720 ?
If this is to support display, this patch should be before display
Make it clear in your commit which omap clk is changing and why.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4
2010-01-24 0:26 ` Tom
@ 2010-01-24 8:37 ` Dirk Behme
0 siblings, 0 replies; 6+ messages in thread
From: Dirk Behme @ 2010-01-24 8:37 UTC (permalink / raw)
To: u-boot
On 24.01.2010 01:26, Tom wrote:
> Khasim Syed Mohammed wrote:
>> From c0bdd7fbdf343ada1ecc65541ec3de1a5fdbfe79 Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim<khasim@ti.com>
>> Date: Mon, 18 Jan 2010 18:51:04 +0530
>> Subject: [PATCH] Add 720Mhz support for Beagle Rev C4
>>
>> Use the Generic TWL and Clock APIs to get beagle
>> Rev C4 running at 720Mhz
>
> Why is it necessary to run mpu at 720 ?
> If this is to support display, this patch should be before display
New BeagleBoard Rev C4 uses a new OMAP3 revision which is able to run
with higher frequency. Switching to 720MHz (from 500MHz) base clock is
to use this general performance improvement. It's independent of
display support.
Best regards
Dirk
> Make it clear in your commit which omap clk is changing and why.
>
> Tom
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-24 8:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-12 19:07 [U-Boot] TI:OMAP: [PATCH 7/7] Add 720Mhz support for Beagle Rev C4 Khasim Syed Mohammed
2010-01-17 0:11 ` Tom
2010-01-18 13:50 ` Khasim Syed Mohammed
-- strict thread matches above, loose matches on Subject: below --
2010-01-18 13:59 Khasim Syed Mohammed
2010-01-24 0:26 ` Tom
2010-01-24 8:37 ` Dirk Behme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox