public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] TI:OMAP: [PATCH 1/7] OMAP3 Beagle Update revision detection
Date: Sat, 16 Jan 2010 18:14:59 -0600	[thread overview]
Message-ID: <4B525683.8000400@windriver.com> (raw)
In-Reply-To: <a8ca84ad1001121101l60ae84b5lb7d4802ba0ca6a3e@mail.gmail.com>

Khasim Syed Mohammed wrote:
> From 15fbe5ff9ee2fd2f8da4c16805d6c7ccf7244bae Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Fri, 8 Jan 2010 20:13:47 +0530
> Subject: [PATCH] OMAP3 Beagle Update revision detection
> 
<snip>

>  	MUX_BEAGLE();
> 
> -	if (beagle_revision_c) {
> +	if (beagle_revision != REVISION_AXBX)
>  		MUX_BEAGLE_C();
> -	}

Because MUX_BEAGLE_C is a multiline macro,
it would be good to keep the '{ }'

>  }
> diff --git a/board/ti/beagle/beagle.h b/board/ti/beagle/beagle.h
> index 7fe6275..b1720c9 100644
> --- a/board/ti/beagle/beagle.h
> +++ b/board/ti/beagle/beagle.h
> @@ -33,7 +33,11 @@ const omap3_sysinfo sysinfo = {
>  #endif
>  };
> 
> -#define BOARD_REVISION_MASK	(0x1 << 11)
> +/* BeagleBoard revisions */
> +#define REVISION_AXBX 	0x7
> +#define REVISION_CX 	0x6
> +#define REVISION_C4 	0x5
> +#define REVISION_D 	0x0
> 
ws
remove spaces at the end of var's in the last 4 lines


Tom

  reply	other threads:[~2010-01-17  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12 19:01 [U-Boot] TI:OMAP: [PATCH 1/7] OMAP3 Beagle Update revision detection Khasim Syed Mohammed
2010-01-17  0:14 ` Tom [this message]
2010-01-18 11:51   ` Khasim Syed Mohammed
2010-01-18 13:07     ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2010-01-18 13:54 Khasim Syed Mohammed
2010-01-24  0:03 ` Tom
2010-01-24  8:59   ` Dirk Behme
2010-01-24 14:26     ` Wolfgang Denk
2010-01-24 19:16       ` Dirk Behme
2010-01-24 19:46         ` Wolfgang Denk
2010-02-06  7:28   ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B525683.8000400@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox