From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 18 Jan 2010 07:27:44 +0100 Subject: [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage) In-Reply-To: <20100115153928.6FA873F6DA@gemini.denx.de> References: <1263376259-29764-1-git-send-email-sbabic@denx.de> <1263376259-29764-2-git-send-email-sbabic@denx.de> <20100115153928.6FA873F6DA@gemini.denx.de> Message-ID: <4B53FF60.3020506@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Stefano Babic, > Hi Wolfgang, > > Line to long. And please try to stick with a consistent error message > format. I see I have too long lines in all patches I have sent. I check this issue for all of them. >> + return (params->dflag && (params->fflag || params->lflag)) || >> + (params->fflag && (params->dflag || params->lflag)) || >> + (params->lflag && (params->dflag || params->fflag)) || >> + (params->xflag) || !(strlen(params->imagename)); > > I cannot understand this code. Well, I will try to simplify this check and, if not possible, I add comments to explain what the code is doing. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================