From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Matthias_Wei=DFer?= <weisserm@arcor.de>
Date: Mon, 18 Jan 2010 08:54:20 +0100
Subject: [U-Boot] [PATCH] Add support for jadecpu board
In-Reply-To: <4B5210EA.8000503@windriver.com>
References: <1263230330-19728-1-git-send-email-matthias.weisser@graf-syteco.de>	<1263230330-19728-2-git-send-email-matthias.weisser@graf-syteco.de>	<1263230330-19728-3-git-send-email-matthias.weisser@graf-syteco.de>	<1263230330-19728-4-git-send-email-matthias.weisser@graf-syteco.de>	<1263230330-19728-5-git-send-email-matthias.weisser@graf-syteco.de>
	<4B5210EA.8000503@windriver.com>
Message-ID: <4B5413AC.2000604@arcor.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom

thanks for your feedback.

Am 16.01.2010 20:18, schrieb Tom:
>> +/*
>> + * Miscellaneous platform dependent initialisations
>> + */
>> +int board_init(void)
>> +{
>
> board_init should fill out entries in
> struct	global_data.
> See other board like lopgicpd/zoom1 as an example.
> Make sure to include the machine id.

As I don't use Linux on this board I don't have such an id. How to deal 
with such a situation? Should I get a machine id anyway? And if so can 
you give me a hint on how I can get such an id?

>> +	/*
>> +	 * (4) IRESET/IUSRRST release
>> +	/*
>
> This looks like a programming error
> /* ->  */  ?

You are right. Thanks for catching this.

>> +#define CONFIG_JADE
>
> The board and cpu defines go first
> move the device configs to later

Can you please explain what you mean with this comment?

>> +#define CONFIG_JADE_IOCLK		(41164767)
>
> This is a strange number. please add a comment.

Well, it is the clock frequency of the IO blocks of the SoC. Its 
14,31818 MHz * 46 / 16. I added a comment.

I have fixed the other stuff you pointed out.

Regards,
Matthias