[U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board

Fabio Estevam
2010-01-11T23:53:32Z

Hi Stefano,

More comments below.

--- On Mon, 1/11/10, Stefano Babic <sbabic@denx.de> wrote:

> From: Stefano Babic <sbabic@denx.de>
> Subject: [U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board
> To: u-boot at lists.denx.de
> Date: Monday, January 11, 2010, 10:26 AM
> The patch adds initial support for
> the Freescale mx51evk board.
> Network (FEC) and SD controller (fsl_esdhc) are supported.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Fred Fan fanyefeng at gmail.com
> ---

....

> +static inline void setup_soc_rev(void)
> +{
> +??? int reg;
> +
> +??? reg = __raw_readl(ROM_SI_REV);
> +??? switch (reg) {
> +??? case 0x02:
> +??? ??? system_rev = 0x51000
> | CHIP_REV_1_1;
> +??? ??? break;
> +??? case 0x10:
> +??? ??? if
> ((__raw_readl(GPIO1_BASE_ADDR + 0x0) & (0x1 <<
> 22)) == 0)
> +??? ??? ???
> system_rev = 0x51000 | CHIP_REV_2_5;
> +??? ??? else
> +??? ??? ???
> system_rev = 0x51000 | CHIP_REV_2_0;
> +??? ??? break;
> +??? default:
> +??? ??? system_rev = 0x51000
> | CHIP_REV_1_0;
> +??? ??? break;
> +??? }
> +}

Looks like CHIP_REV_3_0 case is missing.

...

> +/* CPLD offsets */
> +#define IO_BOARD_OFFSET???
> ??? (0x20000)
> +#define PBC_ID_AAAA??? ???
> (0x20040)
> +#define PBC_ID_5555??? ???
> (0x20048)
> +#define PBC_INT_REST??? ???
> (0x20020)
> +#define PBC_INT_MASK??? ???
> (0x20038)
> +#define PBC_SW_RESET??? ???
> (0x20060)
> +
> +#endif??? ???

There is no CPLD on MX51EVK board. Please remove these defines.

> ??? ??? /*
> __BOARD_FREESCALE_BOARD_MX51_BABBAGE_H__ */

Please remove Babbage references.

Regards,

Fabio Estevam