[U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board

Stefano Babic
2010-01-18T07:34:09Z

Wolfgang Denk wrote:
> Dear Stefano Babic,
>

Hi Wolfgang,

>> +$(obj)u-boot.imx: $(obj)u-boot.bin
>> + $(obj)tools/mkimage -n $(IMX_CONFIG) -T imximage \
>> + -e $(TEXT_BASE) -d $< $@
>
> This actually belongs into the patch that adds the imx image format
> support.

Correct, thanks for the tip. I move it to the right patch.

>> +static void setup_fec(void)
>> +{
>
> FEC should only be set up (and eventually only be reset, too), if
> there is any network support at all on this board.

The name is misleading, too. The FEC is not initialized here and the
function is responsible only to set the IOMUX pin multiplexer for the
network controller. Nothing more. The name shoud be something such as
"set_iomux_network".

I can of course surround the function with #ifdef CONFIG_FEC_MXC, but
really do I need ? We cannot change how the processor's pins are
connected on the board, even if we do not want to add network support
for this board. I think it should be ok if the pin multiplexer is always
configured, independently if there is a network device or not.

>> +#define CONFIG_SYS_APCS_GNU
>
> What's this? It seems to be not used anywhere, nor documented?

I get already rid of the meaningless usage. I forget to drop its define.
Thanks !

>
>> +#define CONFIG_ENV_SECT_SIZE (128 * 1024)
>> +#define CONFIG_ENV_SIZE CONFIG_ENV_SECT_SIZE
>> +#define CONFIG_ENV_IS_NOWHERE
>
> Seems strange to me to define an environment sector size and an
> environment size and then to say there is no environment at all?

Right. The mx51evk board has neither NOR nor NAND flash. However, a SPI
flash is available and this defines are required when the spi will be
supported. At the moment, I can drop them and reinsert later.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================