From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem
Date: Mon, 18 Jan 2010 06:59:32 -0600 [thread overview]
Message-ID: <4B545B34.60908@windriver.com> (raw)
In-Reply-To: <4B540CB8.9030409@st.com>
Vipin KUMAR wrote:
> On 1/18/2010 12:49 PM, Ben Warren wrote:
>>>>>
>>>>> if (chip->cpufreq == -1)
>>>>> @@ -156,6 +215,13 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag,
>>>>> int argc, char *argv[])
>>>>> else
>>>>> printf("DDR Type = Not Known\n");
>>>>>
>>>>> + if (!i2c_read_mac(mac)) {
>>>>> + sprintf(i2c_mac, "%pM", mac);
>>>>> + printf("Ethaddr (from i2c mem) = %s\n", i2c_mac);
>>>>>
>>>> Maybe I'm missing some context, but why's the sprintf needed?
>>>>
>>> Yes, sprintf is not needed here
>>> Thanks for pointing out
>>>
>
> Hello Tom,
> Should I send the whole patch set again or only the subpatch after
> removing the sprintf
Let us wait for feed back from nand and usb subsystem so we
can a accumulate them in just one patch set.
Tom
>
> Regards
> Vipin
next prev parent reply other threads:[~2010-01-18 12:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 13:45 [U-Boot] [PATCH v5 00/12] Support for SPEAr SoCs Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 01/12] SPEAr : Adding README.spear in doc Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 02/12] SPEAr : Adding basic SPEAr architecture support Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 03/12] SPEAr : i2c driver support added for SPEAr SoCs Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 04/12] SPEAr : smi driver support " Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 05/12] SPEAr : nand " Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 06/12] SPEAr : usbd " Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 07/12] SPEAr : Support added for SPEAr600 board Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 09/12] SPEAr : Support added for SPEAr300 board Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 10/12] SPEAr : emi controller initialization for CFI driver support Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 11/12] SPEAr : Support added for SPEAr310 board Vipin KUMAR
2010-01-15 13:45 ` [U-Boot] [PATCH v5 12/12] SPEAr : Support added for SPEAr320 board Vipin KUMAR
2010-01-18 6:15 ` [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem Ben Warren
2010-01-18 7:05 ` Vipin KUMAR
2010-01-18 7:19 ` Ben Warren
2010-01-18 7:24 ` Vipin KUMAR
2010-01-18 12:59 ` Tom [this message]
2010-01-18 7:08 ` Mike Frysinger
2010-02-01 5:15 ` Ben Warren
2010-02-01 13:55 ` Tom
2010-01-18 18:02 ` [U-Boot] [PATCH v5 05/12] SPEAr : nand driver support for SPEAr SoCs Scott Wood
2010-01-17 20:12 ` [U-Boot] [PATCH v5 00/12] Support " Tom
2010-01-18 4:39 ` Vipin KUMAR
2010-01-18 12:51 ` Tom
2010-01-18 19:19 ` Remy Bohmer
2010-01-19 11:52 ` Armando VISCONTI
2010-01-21 21:30 ` Tom
2010-01-22 3:33 ` Vipin KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B545B34.60908@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox