From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Mon, 18 Jan 2010 06:59:32 -0600
Subject: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id
 read/write from i2c mem
In-Reply-To: <4B540CB8.9030409@st.com>
References: <1263563153-408-1-git-send-email-vipin.kumar@st.com>	<1263563153-408-2-git-send-email-vipin.kumar@st.com>	<1263563153-408-3-git-send-email-vipin.kumar@st.com>	<1263563153-408-4-git-send-email-vipin.kumar@st.com>	<1263563153-408-5-git-send-email-vipin.kumar@st.com>	<1263563153-408-6-git-send-email-vipin.kumar@st.com>	<1263563153-408-7-git-send-email-vipin.kumar@st.com>	<1263563153-408-8-git-send-email-vipin.kumar@st.com>
	<1263563153-408-9-git-send-email-vipin.kumar@st.com>
	<4B53FC8F.2000909@gmail.com> <4B540834.7040301@st.com>
	<4B540B68.7030901@gmail.com> <4B540CB8.9030409@st.com>
Message-ID: <4B545B34.60908@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Vipin KUMAR wrote:
> On 1/18/2010 12:49 PM, Ben Warren wrote:
>>>>>  
>>>>>          if (chip->cpufreq == -1)
>>>>> @@ -156,6 +215,13 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag,
>>>>> int argc, char *argv[])
>>>>>          else
>>>>>              printf("DDR Type    = Not Known\n");
>>>>>  
>>>>> +        if (!i2c_read_mac(mac)) {
>>>>> +            sprintf(i2c_mac, "%pM", mac);
>>>>> +            printf("Ethaddr (from i2c mem) = %s\n", i2c_mac);
>>>>>         
>>>> Maybe I'm missing some context, but why's the sprintf needed?
>>>>     
>>> Yes, sprintf is not needed here
>>> Thanks for pointing out
>>>
> 
> Hello Tom,
> Should I send the whole patch set again or only the subpatch after 
> removing the sprintf

Let us wait for feed back from nand and usb subsystem so we
can a accumulate them in just one patch set.

Tom

> 
> Regards
> Vipin