From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Matthias_Wei=DFer?= Date: Mon, 18 Jan 2010 15:01:02 +0100 Subject: [U-Boot] [PATCH] Add support for MB86R01 from Fujitsu In-Reply-To: <4B51DD95.10004@windriver.com> References: <1263230330-19728-1-git-send-email-matthias.weisser@graf-syteco.de> <1263230330-19728-2-git-send-email-matthias.weisser@graf-syteco.de> <4B51DD95.10004@windriver.com> Message-ID: <4B54699E.6070601@arcor.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 16.01.2010 16:39, schrieb Tom: > Matthias Weisser wrote: >> @@ -41,7 +41,8 @@ struct serial_device *__default_serial_console (void) >> #elif defined(CONFIG_405GP) || defined(CONFIG_405CR) || defined(CONFIG_440) \ >> || defined(CONFIG_405EP) || defined(CONFIG_405EZ) || defined(CONFIG_405EX) \ >> || defined(CONFIG_MPC5xxx) || defined(CONFIG_MPC83xx) \ >> - || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) >> + || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) \ >> + || defined(CONFIG_JADE) >> #if defined(CONFIG_CONS_INDEX)&& defined(CONFIG_SYS_NS16550_SERIAL) >> #if (CONFIG_CONS_INDEX==1) >> return&eserial1_device; > > Including serial here is premature. > I do not see where you set up there serial devices. > Please save this for a later serial-only patch. Well, the SoC has UARTs which are fully compatible with the ns16550 driver (drivers/serial/serial.c) and therefore I simply set it up like this. What would be the right way to do it? I don't see a reason to add a serial_mb860x.c driver which is virtually identical to the current stuff in serial.c > Otherwise this patch looks fine. Thanks for checking. Regards, Matthias