From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications
Date: Mon, 18 Jan 2010 20:44:04 +0100 [thread overview]
Message-ID: <4B54BA04.7020509@googlemail.com> (raw)
In-Reply-To: <1263843331-30089-1-git-send-email-biggerbadderben@gmail.com>
On 18.01.2010 20:35, Ben Warren wrote:
> Commit 6a45e384955262882375a2785426dc65aeb636c4 (Make getenv_IPaddr() global)
> inadvertently added ' #include "net.h" ' to the standalone programs, creating
> duplicate definitions of 'struct eth_device'. This patch removes the local
> definitions and removes other code that breaks due to the change in definition.
Yes, great. This looks better than my proposal to fix this some
minutes ago :)
Thanks
Dirk
> Signed-off-by: Ben Warren<biggerbadderben@gmail.com>
> ---
> examples/standalone/smc91111_eeprom.c | 2 --
> examples/standalone/smc911x_eeprom.c | 8 --------
> 2 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/examples/standalone/smc91111_eeprom.c b/examples/standalone/smc91111_eeprom.c
> index 428ea7b..9145763 100644
> --- a/examples/standalone/smc91111_eeprom.c
> +++ b/examples/standalone/smc91111_eeprom.c
> @@ -29,8 +29,6 @@
>
> #include<common.h>
> #include<exports.h>
> -/* the smc91111.h gets base addr through eth_device' iobase */
> -struct eth_device { unsigned long iobase; };
> #include "../drivers/net/smc91111.h"
>
> #ifndef SMC91111_EEPROM_INIT
> diff --git a/examples/standalone/smc911x_eeprom.c b/examples/standalone/smc911x_eeprom.c
> index fff3123..104047f 100644
> --- a/examples/standalone/smc911x_eeprom.c
> +++ b/examples/standalone/smc911x_eeprom.c
> @@ -16,13 +16,6 @@
>
> #include<common.h>
> #include<exports.h>
> -
> -/* the smc911x.h gets base addr through eth_device' iobase */
> -struct eth_device {
> - const char *name;
> - unsigned long iobase;
> - void *priv;
> -};
> #include "../drivers/net/smc911x.h"
>
> /**
> @@ -324,7 +317,6 @@ int smc911x_eeprom(int argc, char *argv[])
> {
> /* Avoid initializing on stack as gcc likes to call memset() */
> struct eth_device dev;
> - dev.name = __func__;
> dev.iobase = CONFIG_SMC911X_BASE;
>
> /* Print the ABI version */
next prev parent reply other threads:[~2010-01-18 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 19:35 [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications Ben Warren
2010-01-18 19:44 ` Dirk Behme [this message]
2010-01-18 22:02 ` Mike Frysinger
2010-01-18 23:06 ` Wolfgang Denk
[not found] ` <4B54D424.304@windriver.com>
2010-01-18 23:15 ` Ben Warren
2010-01-18 23:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B54BA04.7020509@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox