From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] NAND Nomadik: add CONFIG_NAND_NOMADIK_16BIT option
Date: Mon, 18 Jan 2010 17:31:04 -0600 [thread overview]
Message-ID: <4B54EF38.5070404@freescale.com> (raw)
In-Reply-To: <20100118232655.C43B13F6C0@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Alessandro Rubini,
>
> In message <a14c1bde15838a59c60e177a43a4ebd35f28adea.1263851321.git.rubini@unipv.it> you wrote:
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> Cc: Gregory Hermant <gregory.hermant@calao-systems.com>
>> ---
>> drivers/mtd/nand/nomadik.c | 15 +++++++++++----
>> 1 files changed, 11 insertions(+), 4 deletions(-)
>
> New config options should be documented. If not in the REDME, so at
> last in the commit message. You may know what
> CONFIG_NAND_NOMADIK_16BIT is supposed to mean, others may not.
>
> Also, I suggest to change the name into CONFIG_NOMADIK_NAND_16BIT
> which seems more logical to me.
It's an attribute of the hardware, so it should be
CONFIG_SYS_NOMADIK_NAND_16BIT.
-Scott
next prev parent reply other threads:[~2010-01-18 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 22:13 [U-Boot] [PATCH 0/2] Add a new Nomadik board Alessandro Rubini
2010-01-18 22:13 ` [U-Boot] [PATCH 1/2] NAND Nomadik: add CONFIG_NAND_NOMADIK_16BIT option Alessandro Rubini
2010-01-18 23:26 ` Wolfgang Denk
2010-01-18 23:31 ` Scott Wood [this message]
2010-01-19 0:02 ` Alessandro Rubini
2010-01-18 22:13 ` [U-Boot] [PATCH 2/2] Add Nomadik board "usb-s8815" by Calao vendor Alessandro Rubini
2010-01-18 23:32 ` Wolfgang Denk
2010-01-18 23:54 ` Alessandro Rubini
2010-01-22 18:36 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B54EF38.5070404@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox