From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 18 Jan 2010 17:31:04 -0600
Subject: [U-Boot] [PATCH 1/2] NAND Nomadik:
 add	CONFIG_NAND_NOMADIK_16BIT option
In-Reply-To: <20100118232655.C43B13F6C0@gemini.denx.de>
References: <cover.1263851318.git.rubini@unipv.it>	<a14c1bde15838a59c60e177a43a4ebd35f28adea.1263851321.git.rubini@unipv.it>
	<20100118232655.C43B13F6C0@gemini.denx.de>
Message-ID: <4B54EF38.5070404@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Alessandro Rubini,
> 
> In message <a14c1bde15838a59c60e177a43a4ebd35f28adea.1263851321.git.rubini@unipv.it> you wrote:
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> Cc: Gregory Hermant <gregory.hermant@calao-systems.com>
>> ---
>>  drivers/mtd/nand/nomadik.c |   15 +++++++++++----
>>  1 files changed, 11 insertions(+), 4 deletions(-)
> 
> New config options should be documented. If not in the REDME, so at
> last in the commit message. You may know what
> CONFIG_NAND_NOMADIK_16BIT is supposed to mean, others may not.
> 
> Also, I suggest to change the name into CONFIG_NOMADIK_NAND_16BIT
> which seems more logical to me.

It's an attribute of the hardware, so it should be 
CONFIG_SYS_NOMADIK_NAND_16BIT.

-Scott