From: kevin.morfitt at fearnside-systems.co.uk <kevin.morfitt@fearnside-systems.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM] Update the s3c2410 nand driver from linux-2.6.31.5
Date: Tue, 19 Jan 2010 08:40:19 +0000 [thread overview]
Message-ID: <4B556FF3.5080100@fearnside-systems.co.uk> (raw)
In-Reply-To: <20100118201639.GA6490@loki.buserror.net>
Scott Wood wrote:
> On Thu, Nov 05, 2009 at 08:53:36AM +0000, kevin.morfitt at fearnside-systems.co.uk wrote:
>> This patch updates the s3c2410 nand driver from that of linux 2.6.31.5,
>> modified to make it work in the u-boot mtd nand architecture and to allow
>> setting the flash timing parameters from a board config file instead of
>> being hard coded. Note that this modified driver supports s3c2410 and
>> s3c2440.
>>
>> Signed-off-by: Kevin Morfitt <kevin.morfitt@fearnside-systems.co.uk>
>> ---
>>
>> checkpatch.pl shows no errors or warnings, and MAKEALL ARM9 shows no new
>> errors or warnings.
>>
>> Tested on an Embest SBC2440-II Board with local s3c2440 patches as I don't
>> have an s3c2410 board.
>>
>> drivers/mtd/nand/s3c2410_nand.c | 134 +++++++++++++++++--------------
>> include/asm-arm/arch-s3c24x0/s3c2410.h | 25 ++++++
>> 2 files changed, 98 insertions(+), 61 deletions(-)
>
> It looks like this got missed, probably because it either depended on
> something in (or destined for) the ARM tree, or I just assumed that because
> of the "PATCH ARM".
>
> Unfortunately, it doesn't apply cleanly anymore. Could you resend, if it's
> still needed?
It was part of adding s3c2440 support which I've had to re-work quite a lot
and is currently waiting for comments on a set of re-worked patches. I think
it would be simpler if I dropped this one and submitted a replacement later
on. I think the s3c2410 nand driver code is different in the u-boot main,
Samsung SOC, and NAND repositories though so I'm not sure what I should base
a future patch on given that Wolfgang asked me to always base patches on
u-boot master.
>
> -Scott
>
next prev parent reply other threads:[~2010-01-19 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 8:53 [U-Boot] [PATCH ARM] Update the s3c2410 nand driver from linux-2.6.31.5 kevin.morfitt at fearnside-systems.co.uk
2010-01-18 20:16 ` Scott Wood
2010-01-19 8:40 ` kevin.morfitt at fearnside-systems.co.uk [this message]
2010-01-19 16:07 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B556FF3.5080100@fearnside-systems.co.uk \
--to=kevin.morfitt@fearnside-systems.co.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox