From: Magnus Lilja <lilja.magnus@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-V2 4/9] Nand mxc_nand add v1.1 controller support
Date: Wed, 20 Jan 2010 20:51:32 +0100 [thread overview]
Message-ID: <4B575EC4.3080606@gmail.com> (raw)
In-Reply-To: <20100118210258.GC6490@loki.buserror.net>
Scott,
Scott Wood skrev:
> On Sat, Jan 16, 2010 at 09:50:22PM -0700, John Rigby wrote:
>> Add support for version 1.1 of the nfc nand flash
>> controller which is on the i.mx25 soc.
>>
>> Use CONFIG_NAND_MXC_V1 and CONFIG_NAND_MXC_V1_1 to
>> differentiate between the two supported versions.
>>
>> Add a define CONFIG_NAND_MXC_V1 to imx27lite board config.
>>
>> Also factor out some soc specific nand geometry config
>> into a new inline routine and a couple of defines:
>> mxc_get_nfc_info
>> IMX_NFC_IS_16BIT
>> IMX_NFC_IS_2KPAGE
>>
>> Added to imx-regs.h.
>>
>> Signed-off-by: John Rigby <jcrigby@gmail.com>
>> Earlier-version-signed-off-by: Wolfgang Denk <wd@denx.de>
>> CC: Scott Wood <scottwood@freescale.com>
>> CC: Fred Fan <fanyefeng@gmail.com>
>> ---
>
> The 16-bit detection conflicts with
> http://lists.denx.de/pipermail/u-boot/2009-November/064139.html
>
> Which way should I resolve the conflict? Or does one of you want to respin?
> I don't see 16BIT/2KPAGE/get_nfc_info defined for MX31... and does MX25
> share MX27's imx-regs.h?
>
> Magnus, can you test this patch on MX31?
I've now tested the patch and after adding an imx-regs.h for MX31 with the needed information the patch seems to work on i.MX31. Tested on the Litekit board with a small page NAND mounted.
A comment for John Rigby on the patch though: Is it really necessary to specify the version of the NAND controller in the board configuration file? As far as I know, once you select which i.MX-device to use U-boot already has the necessary information to derive the version of the NAND FC automatically.
Regards, Magnus
next prev parent reply other threads:[~2010-01-20 19:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 4:50 [U-Boot] [PATCH-V2 0/9] Add support for i.MX25 SOC and TX25 board John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 1/9] mxc_serial replace platform specific clock John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 2/9] arm926ejs: add nand_spl boot support John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 3/9] Add MX25 support to nand_spl fsl nfc driver John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 4/9] Nand mxc_nand add v1.1 controller support John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 5/9] fec_mxc: cleanup and factor out MX27 dependencies John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 6/9] Add support for Freescale MX25 SOC John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 7/9] fec_mxc: add MX25 support John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 8/9] env_nand.c: print error message and fail gracefully John Rigby
2010-01-17 4:50 ` [U-Boot] [PATCH-V2 9/9] Add support for KARO TX25 board John Rigby
2010-01-25 23:48 ` [U-Boot] [PATCH-V2 8/9] env_nand.c: print error message and fail gracefully Scott Wood
2010-01-18 21:02 ` [U-Boot] [PATCH-V2 4/9] Nand mxc_nand add v1.1 controller support Scott Wood
2010-01-18 21:23 ` Magnus Lilja
2010-01-19 4:11 ` John Rigby
2010-01-19 16:03 ` Scott Wood
2010-01-19 21:02 ` Magnus Lilja
2010-01-19 21:51 ` John Rigby
2010-01-20 19:51 ` Magnus Lilja [this message]
2010-01-20 21:25 ` John Rigby
2010-01-17 17:54 ` [U-Boot] [PATCH-V2 0/9] Add support for i.MX25 SOC and TX25 board Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B575EC4.3080606@gmail.com \
--to=lilja.magnus@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox