From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Lilja Date: Wed, 20 Jan 2010 20:51:32 +0100 Subject: [U-Boot] [PATCH-V2 4/9] Nand mxc_nand add v1.1 controller support In-Reply-To: <20100118210258.GC6490@loki.buserror.net> References: <1263703827-2727-1-git-send-email-jcrigby@gmail.com> <1263703827-2727-2-git-send-email-jcrigby@gmail.com> <1263703827-2727-3-git-send-email-jcrigby@gmail.com> <1263703827-2727-4-git-send-email-jcrigby@gmail.com> <1263703827-2727-5-git-send-email-jcrigby@gmail.com> <20100118210258.GC6490@loki.buserror.net> Message-ID: <4B575EC4.3080606@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott, Scott Wood skrev: > On Sat, Jan 16, 2010 at 09:50:22PM -0700, John Rigby wrote: >> Add support for version 1.1 of the nfc nand flash >> controller which is on the i.mx25 soc. >> >> Use CONFIG_NAND_MXC_V1 and CONFIG_NAND_MXC_V1_1 to >> differentiate between the two supported versions. >> >> Add a define CONFIG_NAND_MXC_V1 to imx27lite board config. >> >> Also factor out some soc specific nand geometry config >> into a new inline routine and a couple of defines: >> mxc_get_nfc_info >> IMX_NFC_IS_16BIT >> IMX_NFC_IS_2KPAGE >> >> Added to imx-regs.h. >> >> Signed-off-by: John Rigby >> Earlier-version-signed-off-by: Wolfgang Denk >> CC: Scott Wood >> CC: Fred Fan >> --- > > The 16-bit detection conflicts with > http://lists.denx.de/pipermail/u-boot/2009-November/064139.html > > Which way should I resolve the conflict? Or does one of you want to respin? > I don't see 16BIT/2KPAGE/get_nfc_info defined for MX31... and does MX25 > share MX27's imx-regs.h? > > Magnus, can you test this patch on MX31? I've now tested the patch and after adding an imx-regs.h for MX31 with the needed information the patch seems to work on i.MX31. Tested on the Litekit board with a small page NAND mounted. A comment for John Rigby on the patch though: Is it really necessary to specify the version of the NAND controller in the board configuration file? As far as I know, once you select which i.MX-device to use U-boot already has the necessary information to derive the version of the NAND FC automatically. Regards, Magnus