From mboxrd@z Thu Jan  1 00:00:00 1970
From: Semih Hazar <semih.hazar@indefia.com>
Date: Thu, 21 Jan 2010 15:13:35 +0200
Subject: [U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board
In-Reply-To: <20100117231747.765FCC88AE@gemini.denx.de>
References: <4B2A2E3A.4070908@indefia.com>
	<20100117231747.765FCC88AE@gemini.denx.de>
Message-ID: <4B5852FF.5080709@indefia.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

Please find my answers below.
>
> Is ther e a chance to do without this file and use the CFI driver
> instead?
>
>   
There's currently a problem with the CFI driver in AVR32 platform. There
was a long discussion about it, but a solution was not available. If
that issue is solved, I can submit a patch to change this to use CFI.
>
>> +	// First 8 sectors are 8k
>>     
> Please do not use C++ comments.
>
>   
These are fixed.
>
>> +	/* Enable GPIO on config swicthes */
>> +	portmux_select_gpio(PORTMUX_PORT_B, (1 << 13) | (1 << 14) | (1 << 15) | (1 << 16),
>>     
> Line too long. Please fix globally.
>
>   
Fixed.
> Line too long. And please use strmhz() to print clock frequencies.
>
> Um... this print does not belong here at all. CPU init messages and
> board initi messages have no place in initdram() at all.
>
>   
Removed it.
>> diff --git a/board/indefia/nimbuscloud/u-boot.lds b/board/indefia/nimbuscloud/u-boot.lds
>> new file mode 100644
>> index 0000000..a7243f2
>> --- /dev/null
>> +++ b/board/indefia/nimbuscloud/u-boot.lds
>>     
> Do you really need a board specific linker script?
>
>
>   
The README file says to put a u-boot.lds file for a new board and I did
so. I also looked at the other AVR32 boards and they all also have it.
If there's another way, I can change it.

I'm sending the revised patch in another mail.

Best regards,
Semih Hazar