From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 21 Jan 2010 13:27:28 -0800 Subject: [U-Boot] [PATCH] cs8900_initialize() cleanup [rev2] In-Reply-To: <20100121211634.GB16182@darwin> References: <20100121211634.GB16182@darwin> Message-ID: <4B58C6C0.8030003@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Matthias, Matthias Kaehlcke wrote: > cs8900_initialize(): remove unecessary calls to free() and fix memory leak > > Signed-off-by: Matthias Kaehlcke > --- > drivers/net/cs8900.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c > index df36004..9424fb2 100644 > --- a/drivers/net/cs8900.c > +++ b/drivers/net/cs8900.c > @@ -308,14 +308,13 @@ int cs8900_initialize(u8 dev_num, int base_addr) > > dev = malloc(sizeof(*dev)); > if (!dev) { > - free(dev); > return 0; > } > memset(dev, 0, sizeof(*dev)); > > priv = malloc(sizeof(*priv)); > if (!priv) { > - free(priv); > + free(dev); > return 0; > } > memset(priv, 0, sizeof(*priv)); > Applied to net repo. thanks, Ben