From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 21 Jan 2010 13:27:55 -0800 Subject: [U-Boot] [PATCH] smc91111_eeprom: fix linking error In-Reply-To: <1264068299-4615-1-git-send-email-vapier@gentoo.org> References: <1264068299-4615-1-git-send-email-vapier@gentoo.org> Message-ID: <4B58C6DB.4090808@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike, Mike Frysinger wrote: > Building for a bf533-stamp ends up with this error: > smc91111_eeprom.o: In function `smc91111_eeprom': > examples/standalone/smc91111_eeprom.c:58: undefined reference to `memset' > make[2]: *** [smc91111_eeprom] Error 1 > > The new eth_struct definition means gcc has to zero out the structure on > the stack, and some gcc versions optimize this with an implicit call to > memset. So tweak the structure style to avoid that gcc feature. > > Signed-off-by: Mike Frysinger > --- > examples/standalone/smc91111_eeprom.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/examples/standalone/smc91111_eeprom.c b/examples/standalone/smc91111_eeprom.c > index 9145763..b91f34c 100644 > --- a/examples/standalone/smc91111_eeprom.c > +++ b/examples/standalone/smc91111_eeprom.c > @@ -53,9 +53,8 @@ int smc91111_eeprom (int argc, char *argv[]) > int c, i, j, done, line, reg, value, start, what; > char input[50]; > > - struct eth_device dev = { > - .iobase = CONFIG_SMC91111_BASE > - }; > + struct eth_device dev; > + dev.iobase = CONFIG_SMC91111_BASE; > > /* Print the ABI version */ > app_startup (argv); > Applied to net repo. thanks, Ben