From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Lilja Date: Sat, 23 Jan 2010 18:08:28 +0100 Subject: [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c In-Reply-To: <20100117230233.23CFDC88AE@gemini.denx.de> References: <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> <20100117230233.23CFDC88AE@gemini.denx.de> Message-ID: <4B5B2D0C.1030907@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Feng and Tom, Is this in a queue somewhere to be merged? If not, could you please apply this and make a pull request for it? Bset regards, Magnus Lilja Wolfgang Denk skrev: > Dear Feng, > > can you please take care of this? > > In message <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> Magnus Lilja wrote: >> Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f, "i.MX31: fix SPI >> driver for shorter than 32 bit" broke 32 bit transfers. This patch >> makes single 32 bit transfer work again. >> >> Transfer lengths that are known not to work will abort and print >> an error message. >> >> Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to >> the MC13783/ATLAS chip (using the 'date' command). >> >> Signed-off-by: Magnus Lilja >> --- >> >> As discussed on the mailing list, Guennadi Liakhovetski thinks that >> all transfers > 16 bits are broken. This patch fixes the 32 bit case >> and makes sure the user is notified if a broken bitlength is used. >> >> drivers/spi/mxc_spi.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) > > Acked-by: Wolfgang Denk > > Best regards, > > Wolfgang Denk >