public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] TI:OMAP:[PATCH 4/7] Add support for 720Mhz
Date: Sat, 23 Jan 2010 18:09:48 -0600	[thread overview]
Message-ID: <4B5B8FCC.2080105@windriver.com> (raw)
In-Reply-To: <a8ca84ad1001180557o5c6f1ebbve5e1f04b344c0758@mail.gmail.com>

Khasim Syed Mohammed wrote:
> From 977856ac122e451a8de195d9f22253196572157a Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Tue, 12 Jan 2010 16:32:42 +0530
> Subject: [PATCH] Add support for 720Mhz
> 
> A New API to allow setting M value to support 720Mhz
> 
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> ---
>  cpu/arm_cortexa8/omap3/clock.c |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu/arm_cortexa8/omap3/clock.c b/cpu/arm_cortexa8/omap3/clock.c
> index 174c453..d67517a 100644
> --- a/cpu/arm_cortexa8/omap3/clock.c
> +++ b/cpu/arm_cortexa8/omap3/clock.c
> @@ -402,3 +402,24 @@ void per_clocks_enable(void)
> 
>  	sdelay(1000);
>  }
> +
> +/*
> + * Configure PRCM registers to get 720 Mhz
> + *
> + * NOTE: N value doesn't change, only M gets affected
> + */
> +void prcm_config_720mhz(void)
> +{

Generalize this
Change the name prcm_config.
Possiblly pass in an enum for supported clk.

Setting the omap clk is not this simple.
It is dependent on at least the input frequency.
I do not see where this is checked here.
You should rethink how this is being done.

Move this to the beagle board dir.

Tom

  reply	other threads:[~2010-01-24  0:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 13:57 [U-Boot] TI:OMAP:[PATCH 4/7] Add support for 720Mhz Khasim Syed Mohammed
2010-01-24  0:09 ` Tom [this message]
2010-01-25 14:04   ` Khasim Syed Mohammed
2010-01-25 15:03     ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2010-01-12 19:04 Khasim Syed Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5B8FCC.2080105@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox