From: Armando VISCONTI <armando.visconti@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC 0/2] dcache on ARM
Date: Tue, 26 Jan 2010 18:59:14 +0100 [thread overview]
Message-ID: <4B5F2D72.8080107@st.com> (raw)
In-Reply-To: <20100126173634.GA22384@morgana.gnudd.com>
>
>> I don't see the flush_cache() call inside cmd_bootm.c.
>> Don't you think it is necessary before jumping to Linux?
>>
>
> Yes, definitely. Actually, I checked it, but re-checking now I see
> I've been tricked by '[id]cache_disable' being grepped successfully in
> common/cmd_bootm.c . However, it's inside a false ifdef.
>
> I'm booting through the network, so that's probably why it works
> reliably for me (netboot_common does the propre flushing).
>
Right, cache_disable() should be called to do the proper
job, i.e. cache disabling and flushing.
OK, we can wait for more comments but if there are no other architectural
drawbacks I can't think of I'm willing to test it on
SPEAr achitecture as well. Actually I have always thought about
enabling dcache, but too lazy to implement/verify it :-(
Thx,
Arm
--
-- "Every step appears to be the unavoidable consequence of the
-- preceding one." (A. Einstein)
--
Armando Visconti Mobile: (+39) 346 8879146
Senior SW Engineer Fax: (+39) 02 93519290
CPG Work: (+39) 02 93519683
Computer System Division e-mail: armando.visconti at st.com
ST Microelectronics TINA: 051 4683
prev parent reply other threads:[~2010-01-26 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 16:16 [U-Boot] [PATCH RFC 0/2] dcache on ARM Alessandro Rubini
2010-01-26 17:13 ` Nick Thompson
2010-01-26 21:50 ` Alessandro Rubini
2010-01-26 17:21 ` Armando VISCONTI
2010-01-26 17:36 ` Alessandro Rubini
2010-01-26 17:59 ` Armando VISCONTI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F2D72.8080107@st.com \
--to=armando.visconti@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox