From mboxrd@z Thu Jan 1 00:00:00 1970 From: Armando VISCONTI Date: Tue, 26 Jan 2010 18:59:14 +0100 Subject: [U-Boot] [PATCH RFC 0/2] dcache on ARM In-Reply-To: <20100126173634.GA22384@morgana.gnudd.com> References: <4B5F2495.2050009@st.com> <20100126161608.GA20946@morgana.gnudd.com> <20100126173634.GA22384@morgana.gnudd.com> Message-ID: <4B5F2D72.8080107@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > >> I don't see the flush_cache() call inside cmd_bootm.c. >> Don't you think it is necessary before jumping to Linux? >> > > Yes, definitely. Actually, I checked it, but re-checking now I see > I've been tricked by '[id]cache_disable' being grepped successfully in > common/cmd_bootm.c . However, it's inside a false ifdef. > > I'm booting through the network, so that's probably why it works > reliably for me (netboot_common does the propre flushing). > Right, cache_disable() should be called to do the proper job, i.e. cache disabling and flushing. OK, we can wait for more comments but if there are no other architectural drawbacks I can't think of I'm willing to test it on SPEAr achitecture as well. Actually I have always thought about enabling dcache, but too lazy to implement/verify it :-( Thx, Arm -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior SW Engineer Fax: (+39) 02 93519290 CPG Work: (+39) 02 93519683 Computer System Division e-mail: armando.visconti at st.com ST Microelectronics TINA: 051 4683