[U-Boot] [PATCH 5/9 V3] convert common files to new SoC access

Jens Scharsig
2010-01-31T16:15:45Z

Tom wrote:
>> * convert common files in cpu/../at91 and a lot of drivers to use
chose>>
>> #include <common.h>
>> +#ifndef CONFIG_AT91_LEGACY
>
> This should be
> #ifdef CONFIG_AT91_LEGACY
> The additions you made to the board configs should take care of this.
> Perhaps add an
> #ifndef CONFIG_AT91_LEGACY
> #error "Error this is legacy code"
> Fix globally
>

I have chosen this way, to let the compilation of the affected
files possible. -> Warnings instead of errors

>> - AT91_PMC_USB96M;
>> + AT91_PMC_PLLBR_USBDIV_2;
>
> The name of this define should not have changed
> This is reoccurring problem in this patchset.
> Revert globally

AT91_PMC_USB96M is not a valid flag name for at91 soc's,
it's legacy code
>
>
> This is new
> and not a simple structure change.
> This should go into its own patch
>
regards Jens