public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9 V3] convert common files to new SoC access
Date: Sun, 31 Jan 2010 17:15:45 +0100	[thread overview]
Message-ID: <4B65ACB1.608@scharsoft.de> (raw)
In-Reply-To: <4B64DAC0.3090404@windriver.com>

Tom wrote:
>> * convert common files in cpu/../at91 and a lot of drivers to use
chose>>  
>>  #include <common.h>
>> +#ifndef CONFIG_AT91_LEGACY
> 
> This should be
> #ifdef CONFIG_AT91_LEGACY
> The additions you made to the board configs should take care of this.
> Perhaps add an
> #ifndef CONFIG_AT91_LEGACY
> #error "Error this is legacy code"
> Fix globally
> 

I have chosen this way, to let the compilation of the affected 
files possible. -> Warnings instead of errors

>> -			     AT91_PMC_USB96M;
>> +			     AT91_PMC_PLLBR_USBDIV_2;
> 
> The name of this define should not have changed
> This is reoccurring problem in this patchset.
> Revert globally

AT91_PMC_USB96M is not a valid flag name for at91 soc's,
it's legacy code
> 
> 
> This is new
> and not a simple structure change.
> This should go into its own patch
> 
regards Jens

  reply	other threads:[~2010-01-31 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-23 11:03 [U-Boot] [PATCH 5/9 V3] convert common files to new SoC access Jens Scharsig
2010-01-31  1:20 ` Tom
2010-01-31 16:15   ` Jens Scharsig [this message]
2010-02-03 21:46 ` [U-Boot] [PATCH 5/9 V4] " Jens Scharsig
2010-02-10 11:25   ` Daniel Gorsulowski
2010-02-11  7:38     ` Daniel Gorsulowski
2010-02-11  7:52   ` Daniel Gorsulowski
2010-02-11  9:11     ` Daniel Gorsulowski
2010-02-14 11:25     ` Jens Scharsig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B65ACB1.608@scharsoft.de \
    --to=js_at_ng@scharsoft.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox