From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Scharsig Date: Sun, 31 Jan 2010 17:15:45 +0100 Subject: [U-Boot] [PATCH 5/9 V3] convert common files to new SoC access In-Reply-To: <4B64DAC0.3090404@windriver.com> References: <4B5AD783.7080904@scharsoft.de> <4B64DAC0.3090404@windriver.com> Message-ID: <4B65ACB1.608@scharsoft.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Tom wrote: >> * convert common files in cpu/../at91 and a lot of drivers to use chose>> >> #include >> +#ifndef CONFIG_AT91_LEGACY > > This should be > #ifdef CONFIG_AT91_LEGACY > The additions you made to the board configs should take care of this. > Perhaps add an > #ifndef CONFIG_AT91_LEGACY > #error "Error this is legacy code" > Fix globally > I have chosen this way, to let the compilation of the affected files possible. -> Warnings instead of errors >> - AT91_PMC_USB96M; >> + AT91_PMC_PLLBR_USBDIV_2; > > The name of this define should not have changed > This is reoccurring problem in this patchset. > Revert globally AT91_PMC_USB96M is not a valid flag name for at91 soc's, it's legacy code > > > This is new > and not a simple structure change. > This should go into its own patch > regards Jens