public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: remove symbolic links in tools/
Date: Fri, 05 Feb 2010 17:08:38 -0800	[thread overview]
Message-ID: <4B6CC116.30607@gmail.com> (raw)
In-Reply-To: <201002051901.40621.vapier@gentoo.org>

On 2/5/2010 4:01 PM, Mike Frysinger wrote:
> On Friday 05 February 2010 18:49:37 Alessandro Rubini wrote:
>    
>> Older versions created symbolic links for e.g. crc32.c.
>> If such link remains in a tree, current Makefiles will use CC
>> instead of HOSTCC to compile it; this results in a linker error.
>> To be safe, let's remove any link from earlier checkouts.
>>      
> current policy is to run `git clean -x -d` after a `git pull`, but i dont care either way
>
>    
>> --- a/Makefile
>> +++ b/Makefile
>>   	@[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l -print | xargs rm -f
>>   	@[ ! -d $(obj)onenand_ipl ] || find $(obj)onenand_ipl -name "*" -type l -print | xargs rm -f
>> 	@[ ! -d $(obj)tools ] || find $(obj)tools -name "*" -type l -print | xargs rm -f
>>      
> not related directly to your patch, but these -name '*' are useless
>
> also, why not just scan the entire tree:
> 	@[ ! -d $(obj) ] || find $(obj) -type l -print | xargs rm -f
> -mike
>    
>    
And 'find' had a '-delete' switch.  Not sure how long it's been there.

regards,
Ben

  reply	other threads:[~2010-02-06  1:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-05 23:49 [U-Boot] [PATCH] Makefile: remove symbolic links in tools/ Alessandro Rubini
2010-02-06  0:01 ` Mike Frysinger
2010-02-06  1:08   ` Ben Warren [this message]
2010-02-06  1:36     ` Mike Frysinger
2010-02-06  8:06       ` Alessandro Rubini
2010-02-06 14:19         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6CC116.30607@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox