From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Fri, 05 Feb 2010 17:08:38 -0800 Subject: [U-Boot] [PATCH] Makefile: remove symbolic links in tools/ In-Reply-To: <201002051901.40621.vapier@gentoo.org> References: <20100205234937.GA13203@morgana.gnudd.com> <201002051901.40621.vapier@gentoo.org> Message-ID: <4B6CC116.30607@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/5/2010 4:01 PM, Mike Frysinger wrote: > On Friday 05 February 2010 18:49:37 Alessandro Rubini wrote: > >> Older versions created symbolic links for e.g. crc32.c. >> If such link remains in a tree, current Makefiles will use CC >> instead of HOSTCC to compile it; this results in a linker error. >> To be safe, let's remove any link from earlier checkouts. >> > current policy is to run `git clean -x -d` after a `git pull`, but i dont care either way > > >> --- a/Makefile >> +++ b/Makefile >> @[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l -print | xargs rm -f >> @[ ! -d $(obj)onenand_ipl ] || find $(obj)onenand_ipl -name "*" -type l -print | xargs rm -f >> @[ ! -d $(obj)tools ] || find $(obj)tools -name "*" -type l -print | xargs rm -f >> > not related directly to your patch, but these -name '*' are useless > > also, why not just scan the entire tree: > @[ ! -d $(obj) ] || find $(obj) -type l -print | xargs rm -f > -mike > > And 'find' had a '-delete' switch. Not sure how long it's been there. regards, Ben