public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
Date: Sat, 06 Feb 2010 08:30:05 +0100	[thread overview]
Message-ID: <4B6D1A7D.3030408@googlemail.com> (raw)
In-Reply-To: <4B5B8EC1.2020509@windriver.com>

On 24.01.2010 01:05, Tom wrote:
> Khasim Syed Mohammed wrote:
>>  From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim<khasim@ti.com>
>> Date: Mon, 18 Jan 2010 18:11:14 +0530
>> Subject: [PATCH] Enable I2C bus switching
>>
>> OMAP3 supports Multiple I2C channels, this patch allows
>> us to use i2c dev<bus no>  command to switch between busses.
>>
>> Signed-off-by: Syed Mohammed Khasim<khasim@ti.com>
>> Acked-by: Heiko Schocher<hs@denx.de>
>> ---
>>   drivers/i2c/omap24xx_i2c.c     |    5 +++++
>>   include/configs/omap3_beagle.h |    6 ++++++
>>   2 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>> index ff18991..e8c8184 100644
>> --- a/drivers/i2c/omap24xx_i2c.c
>> +++ b/drivers/i2c/omap24xx_i2c.c
>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>
>>   	return 0;
>>   }
>> +
>> +int i2c_get_bus_num(void)
>> +{
>> +	return (int) current_bus;
>> +}
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index a8abb0e..4d516a4 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -100,6 +100,12 @@
>>   /* DDR - I use Micron DDR */
>>   #define CONFIG_OMAP3_MICRON_DDR		1
>>
>> +/* Enable Multi Bus support for I2C */
>> +#define CONFIG_I2C_MULTI_BUS		1
>> +
>> +/* Probe all devices */
>> +#define CONFIG_SYS_I2C_NOPROBES		{0x0, 0x0}
>
> Most/All of the configs I reviewed set the addr element
> to a valid address.  I do not believe 0 is a valid address
> on omap.  If the intent is a double negative
> {0, 0} == probe all
> Then add a comment.

I would fix this, but I have no idea what to add :( Any hint?

Dirk

  parent reply	other threads:[~2010-02-06  7:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 13:55 [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching Khasim Syed Mohammed
2010-01-24  0:05 ` Tom
2010-01-25 14:10   ` Khasim Syed Mohammed
2010-01-25 15:07     ` Tom
2010-02-06  7:30   ` Dirk Behme [this message]
2010-02-07  6:32     ` Ben Warren
2010-02-08  7:01       ` [U-Boot] [beagleboard] " Syed
2010-02-08 13:28         ` Tom
2010-02-08 17:36         ` Ben Warren
2010-02-08 20:26         ` Dirk Behme
  -- strict thread matches above, loose matches on Subject: below --
2010-01-12 19:02 [U-Boot] " Khasim Syed Mohammed
2010-01-17  0:19 ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6D1A7D.3030408@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox