public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nick Thompson <nick.thompson@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] da830evm: Add support for TI EMAC
Date: Tue, 09 Feb 2010 17:15:03 +0000	[thread overview]
Message-ID: <4B719817.6020203@ge.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D98B20B70@dlee01.ent.ti.com>

On 09/02/10 16:47, Paulraj, Sandeep wrote:
>> Adds support for ethernet networking on the da830evm platform.
>>
>> This platform uses an SoC EMAC interface and a 3 port ethernet
>> switch as a PHY with an RMII interface. The PHY also has a i2c
>> interface for configuring the switch functions.
>>
>> Signed-off-by: Nick Thompson <nick.thompson@ge.com>
>> ---
>>  board/davinci/da830evm/da830evm.c        |   65
>> +++++++++++++++++++++++++++++-
>>  include/asm-arm/arch-davinci/emac_defs.h |    1 +
>>  include/configs/da830evm.h               |    1 +
>>  3 files changed, 65 insertions(+), 2 deletions(-)
> 
> 
> Did you test this after integrating the EMAC driver patch in your tree?
> That patch ack'ed by Ben is not yet in my tree.
> 
> I've not yet done a rebase with wd's tree as most of the TI patches are only in the ARM tree.

Hmm, yes. Maybe it's too early to put this in yet. I have the EMAC
patch here as Ben added to his tree, so it is tested correctly, but
there is no way it will work for anybody else :(

Since I only just submitted, its too early to add this to your tree
anyway, but feel free to wait until you tree is updated with the
EMAC patch, or else just NAK it and I'll resubmit later.

Its a minor point really: the da830 build is not broken by this
patch, but its presence implies functionality that doesn't
yet work and it might cause undefined behaviour.

Nick.

      reply	other threads:[~2010-02-09 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09 16:34 [U-Boot] [PATCH v2] da830evm: Add support for TI EMAC Nick Thompson
2010-02-09 16:47 ` Paulraj, Sandeep
2010-02-09 17:15   ` Nick Thompson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B719817.6020203@ge.com \
    --to=nick.thompson@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox