From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Tue, 09 Feb 2010 21:40:01 -0800
Subject: [U-Boot] [PATCH 3/3] SAMSUNG: SMDKC100: Adds ethernet support.
In-Reply-To: <ef0d8a251002092053s67b44c2cvf7c3063925fad36d@mail.gmail.com>
References: <1265707341-25956-1-git-send-email-ch.naveen@samsung.com>
	<1265708302-15743-1-git-send-email-ch.naveen@samsung.com>
	<f8328f7c1002090652w6852883dub6f0236a249a1753@mail.gmail.com>
	<ef0d8a251002092053s67b44c2cvf7c3063925fad36d@mail.gmail.com>
Message-ID: <4B7246B1.2060406@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Naveen,

On 2/9/2010 8:53 PM, Naveen Krishna Ch wrote:
> Hi Ben,
>
> I think you wanted me to remove the CONFIG_BOOTP_* macros.
> But the gmail is showing some other code under ur comments.
>
> Any how i wil remove the CONFIG_BOOTP_* macros and submit a
> V2 version of the patch.
>
I don't have a problem with the CONFIG_BOOTP macros as long as you put 
them there intentionally rather than as a cut&paste.  My quarrel was 
with the MAC and IP address assignments.  It looks like you've removed 
those, so it's all OK.

regards,
Ben