public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/9 V4] add new CONFIG_AT91_LEGACY
Date: Thu, 11 Feb 2010 07:56:08 -0600	[thread overview]
Message-ID: <4B740C78.40500@windriver.com> (raw)
In-Reply-To: <4B72997A.9070701@esd.eu>

Daniel Gorsulowski wrote:
> Hello Tom,
> 
> Tom wrote:
>> Jens Scharsig wrote:
>>> * add's the new temporary CONFIG_AT91_LEGACY to all board configs
>>>  This will need for backward compatiblity, while change the SoC access
>>>  to c structures. If CONFIG_AT91_LEGACY is defined, the deprecated
>>>  SoC is used.
>>>
>>>
>>> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
>> This looks good.
>> The only problem is the new at91 target otc570 is breaking.
>>
>> Please take a look at errors in otc570
>>
>> otc570 :
>>
>> at91sam9263_devices.c: In function 'at91_serial0_hw_init':
>> at91sam9263_devices.c:40: warning: implicit declaration of function 
>> 'at91_set_a_periph'
>> at91sam9263_devices.c: In function 'at91_spi0_hw_init':
>> at91sam9263_devices.c:96: warning: implicit declaration of function 
>> 'at91_set_b_periph'
>> at91sam9263_devices.c:116: warning: implicit declaration of function 
>> 'at91_set_pio_output'
>> clock.c: In function 'at91_clock_init':
>> clock.c:160: warning: implicit declaration of function 'at91_sys_read'
>> clock.c:160: error: 'AT91_CKGR_MCFR' undeclared (first use in this function)
>> clock.c:160: error: (Each undeclared identifier is reported only once
>> clock.c:160: error: for each function it appears in.)
>>
>> Tom
> 
> This is caused by missing defines in include\configs\otc570.h:
> #define CONFIG_AT91_LEGACY
> and
> #define CONFIG_AT91_GPIO	1
> 
> Should I send a patch to fix this, or should I wait for Jens patches coming
> mainline?
> 

Please send a patch.
It should be a 2-3 liner.
I will combine it with Jens' patchset and push them together.
Tom

> Best regards,
> Daniel Gorsulowski

  reply	other threads:[~2010-02-11 13:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-23 11:03 [U-Boot] [PATCH 1/9 V3] add new CONFIG_AT91_LEGACY Jens Scharsig
2010-01-31  0:57 ` Tom
2010-01-31 11:24 ` [U-Boot] [PATCH 1/9 V3.1] " Jens Scharsig
2010-02-03 21:45 ` [U-Boot] [PATCH 1/9 V4] " Jens Scharsig
2010-02-06 14:19   ` Tom
2010-02-10 11:33     ` Daniel Gorsulowski
2010-02-11 13:56       ` Tom [this message]
2010-02-12  6:47         ` Daniel Gorsulowski
2010-02-12 13:08           ` Tom
2010-02-12 18:05           ` Tom
2010-02-13 11:12             ` Daniel Gorsulowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B740C78.40500@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox