From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/eth.c: bug-fix
Date: Thu, 11 Feb 2010 21:53:30 -0800 [thread overview]
Message-ID: <4B74ECDA.3020309@gmail.com> (raw)
In-Reply-To: <07A6D2B84CB942DD8FC96FB7E3CD9CC2@smartbridges.com>
On 2/11/2010 8:08 PM, Teh Kok How wrote:
> --- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.000000000 +0800
>
> +++ u-boot-2009.11.1/net/eth.c 2010-02-12 11:18:23.558229895 +0800
>
> @@ -199,7 +199,7 @@
>
> #endif
>
> /* Try board-specific initialization first. If it fails or isn't
>
> * present, try the cpu-specific initialization */
>
> - if (board_eth_init(bis)< 0)
>
> + if (board_eth_init(bis)<= 0)
>
> cpu_eth_init(bis);
>
>
That's not a bug. The check is meant to indicate whether the weak
board_eth_init() function has been overridden, not whether there was an
error. I have a clarification patch that hasn't been submitted yet.
regards,
Ben
next prev parent reply other threads:[~2010-02-12 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 4:08 [U-Boot] [PATCH] net/eth.c: bug-fix Teh Kok How
2010-02-12 5:53 ` Ben Warren [this message]
2010-02-12 6:57 ` Teh Kok How
2010-02-12 15:19 ` Ben Warren
2010-02-12 9:26 ` Teh Kok How
2010-03-21 20:38 ` Wolfgang Denk
2010-03-23 17:15 ` Ben Warren
2010-03-23 19:52 ` Wolfgang Denk
2010-03-23 20:23 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B74ECDA.3020309@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox