From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 11 Feb 2010 21:53:30 -0800
Subject: [U-Boot] [PATCH] net/eth.c: bug-fix
In-Reply-To: <07A6D2B84CB942DD8FC96FB7E3CD9CC2@smartbridges.com>
References: <07A6D2B84CB942DD8FC96FB7E3CD9CC2@smartbridges.com>
Message-ID: <4B74ECDA.3020309@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2/11/2010 8:08 PM, Teh Kok How wrote:
> --- u-boot-2009.11.1.orig/net/eth.c     2010-01-25 16:35:12.000000000 +0800
>
> +++ u-boot-2009.11.1/net/eth.c  2010-02-12 11:18:23.558229895 +0800
>
> @@ -199,7 +199,7 @@
>
>   #endif
>
>          /* Try board-specific initialization first.  If it fails or isn't
>
>           * present, try the cpu-specific initialization */
>
> -       if (board_eth_init(bis)<  0)
>
> +       if (board_eth_init(bis)<= 0)
>
>                  cpu_eth_init(bis);
>
>    
That's not a bug.  The check is meant to indicate whether the weak 
board_eth_init() function has been overridden, not whether there was an 
error.  I have a clarification patch that hasn't been submitted yet.

regards,
Ben