* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
@ 2010-02-12 9:29 Minkyu Kang
2010-02-17 10:36 ` Minkyu Kang
0 siblings, 1 reply; 6+ messages in thread
From: Minkyu Kang @ 2010-02-12 9:29 UTC (permalink / raw)
To: u-boot
Because adds support the GPIO Interface, README file is updated.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
doc/README.s5pc1xx | 18 +++++++++++++++++-
1 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/doc/README.s5pc1xx b/doc/README.s5pc1xx
index 5a0fe33..ab1f024 100644
--- a/doc/README.s5pc1xx
+++ b/doc/README.s5pc1xx
@@ -41,7 +41,23 @@ To check SoC:
printf("cpu is s5pc110\n");
gpio
- not supported yet.
+
+ struct s5pc100_gpio *gpio = (struct s5pc100_gpio*)S5PC100_GPIO_BASE;
+
+ /* GPA[0] pin set to irq */
+ gpio_cfg_pin(&gpio->gpio_a, 0, GPIO_IRQ);
+
+ /* GPA[0] pin set to input */
+ gpio_direction_input(&gpio->gpio_a, 0);
+
+ /* GPA[0] pin set to output/high */
+ gpio_direction_output(&gpio->gpio_a, 0, 1);
+
+ /* GPA[0] value set to low */
+ gpio_set_value(&gpio->gpio_a, 0, 0);
+
+ /* get GPA[0] value */
+ value = gpio_get_value(&gpio->gpio_a, 0);
Links
=====
--
1.5.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
2010-02-12 9:29 [U-Boot] [PATCH 2/2] s5pc1xx: update the README file Minkyu Kang
@ 2010-02-17 10:36 ` Minkyu Kang
2010-02-17 11:58 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Minkyu Kang @ 2010-02-17 10:36 UTC (permalink / raw)
To: u-boot
On 12 February 2010 18:29, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Because adds support the GPIO Interface, README file is updated.
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> ?doc/README.s5pc1xx | ? 18 +++++++++++++++++-
> ?1 files changed, 17 insertions(+), 1 deletions(-)
>
applied to u-boot-samsung
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
2010-02-17 10:36 ` Minkyu Kang
@ 2010-02-17 11:58 ` Wolfgang Denk
2010-02-17 14:29 ` Minkyu Kang
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2010-02-17 11:58 UTC (permalink / raw)
To: u-boot
Dear Minkyu Kang,
In message <1f3430fb1002170236q7bdb3262q1eb929fdafab2f65@mail.gmail.com> you wrote:
> On 12 February 2010 18:29, Minkyu Kang <mk7.kang@samsung.com> wrote:
> > Because adds support the GPIO Interface, README file is updated.
> >
> > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> > doc/README.s5pc1xx | =A0 18 +++++++++++++++++-
> > 1 files changed, 17 insertions(+), 1 deletions(-)
>
> applied to u-boot-samsung
Would it be possible to squash these two commits into one? They
actually are one change and should not be split apart. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The amount of time between slipping on the peel and landing on the
pavement is precisely 1 bananosecond.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
2010-02-17 11:58 ` Wolfgang Denk
@ 2010-02-17 14:29 ` Minkyu Kang
2010-02-17 20:26 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Minkyu Kang @ 2010-02-17 14:29 UTC (permalink / raw)
To: u-boot
Dear Wolfgang,
On 17 February 2010 20:58, Wolfgang Denk <wd@denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <1f3430fb1002170236q7bdb3262q1eb929fdafab2f65@mail.gmail.com> you wrote:
>> On 12 February 2010 18:29, Minkyu Kang <mk7.kang@samsung.com> wrote:
>> > Because adds support the GPIO Interface, README file is updated.
>> >
>> > Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> > ---
>> > doc/README.s5pc1xx | =A0 18 +++++++++++++++++-
>> > 1 files changed, 17 insertions(+), 1 deletions(-)
>>
>> applied to u-boot-samsung
>
> Would it be possible to squash these two commits into one? They
> actually are one change and should not be split apart. ?Thanks.
I already pushed these patches.
Do I need to revert the patchset?
Or, give me your opinion, if you have any idea.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The amount of time between slipping on the peel and ?landing ?on ?the
> pavement is precisely 1 bananosecond.
>
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
2010-02-17 14:29 ` Minkyu Kang
@ 2010-02-17 20:26 ` Wolfgang Denk
2010-02-18 0:34 ` Minkyu Kang
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2010-02-17 20:26 UTC (permalink / raw)
To: u-boot
Dear Minkyu Kang,
In message <1f3430fb1002170629p2528fdd2x3ffa396775715e8f@mail.gmail.com> you wrote:
>
> > Would it be possible to squash these two commits into one? They
> > actually are one change and should not be split apart. =A0Thanks.
>
> I already pushed these patches.
> Do I need to revert the patchset?
> Or, give me your opinion, if you have any idea.
If you agree, you can "git rebase -i" your branch and squash the two
commits into one.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
several applications can crash at the same time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/2] s5pc1xx: update the README file
2010-02-17 20:26 ` Wolfgang Denk
@ 2010-02-18 0:34 ` Minkyu Kang
0 siblings, 0 replies; 6+ messages in thread
From: Minkyu Kang @ 2010-02-18 0:34 UTC (permalink / raw)
To: u-boot
Dear Wolfgang,
On 18 February 2010 05:26, Wolfgang Denk <wd@denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <1f3430fb1002170629p2528fdd2x3ffa396775715e8f@mail.gmail.com> you wrote:
>>
>> > Would it be possible to squash these two commits into one? They
>> > actually are one change and should not be split apart. =A0Thanks.
>>
>> I already pushed these patches.
>> Do I need to revert the patchset?
>> Or, give me your opinion, if you have any idea.
>
> If you agree, you can "git rebase -i" your branch and squash the two
> commits into one.
I did it.
But, there are remained old two commits.
Did I something wrong?
I appreciate your help.
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-18 0:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 9:29 [U-Boot] [PATCH 2/2] s5pc1xx: update the README file Minkyu Kang
2010-02-17 10:36 ` Minkyu Kang
2010-02-17 11:58 ` Wolfgang Denk
2010-02-17 14:29 ` Minkyu Kang
2010-02-17 20:26 ` Wolfgang Denk
2010-02-18 0:34 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox