From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Fri, 13 Nov 2009 10:03:16 -0000
Subject: [U-Boot] redundant code in common/cmd_i2c.
In-Reply-To: <m2ws1vkdus.fsf@ohwell.denx.de>
References: <880fa7950911110714w54afa0a4h896dcb64dc82e4c0@mail.gmail.com>
	<4AFBC3DD.5080800@denx.de> <m2ws1vkdus.fsf@ohwell.denx.de>
Message-ID: <4B785ACE.2040302@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Detlev,

Detlev Zundel wrote:
>> Hello PratapChandu,
>>
>> PratapChandu wrote:
>>> The following code fragment in the file common/cmd_i2c.c  seems to be redundant.
>>> Is not good to delete  ?
>>>
>>> Line 330 - 336 is like below
>>>
>>> #if 0
>>>         for (timeout = 0; timeout < 10; timeout++) {
>>>             udelay(2000);
>>>             if (i2c_probe(chip) == 0)
>>>                 break;
>>>         }
>>> #endif
>> Yes, this seems to be dead code. Please provide a patch for removing
>> it.
> 
> Ah uh, check the comment above which is directly related to this piece
> of code.  if you remove only the code, you have a dangling comment.
> Maybe this was meant to be an option but nobody cared to make it
> optional?

Yep, you are right, a patch schould fix the comment too, or (maybe better?)
make this as an option configurable ...

> Actually I do not know if this was ever used, but we should try to do
> the change consistently.

Yep.

Thanks for detecting this!

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany